-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2.11.0.build=1] pin cartopy<0.24 and curl<8.10 and pandas<2.2.0 and change to build 1 #29
Conversation
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( For recipe/meta.yaml:
|
…nda-forge-pinning 2024.10.14.02.03.33
Do we want to consider these? |
no - we don't have an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I don't really like this hard pin on the Python version to be honest, but it's probably safer that way.
I am also still not quite sure if we can really dismiss the comments by @conda-forge-admin so easily, but let's discuss this when we release v2.12.0.
Thanks V for taking care of this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you asked me to look at it, have an approve 👍
packages are pinned to what was discussed to avoid issues, can't really comment on the comments. Hard pin on python will only be until the next release so should be fine.
oh I absolutely hate the Python<3.12 pin myself, bud, especially now that we have full functionality for it in the main branch - but, I reckon better safe than sorry - we can always come back and rebuild with it, but you know - this way is the closest one can get to the actual 2.11 (bar a lock file that would completely freeze the deps and builds at the moment of 2.11 release). About what c-f is suggesting - it's not possible, since |
cheers Manu 🍺 |
excellent, cheers, Tina 🍺 |
Checklist
[ ] Reset the build number to0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)Changes needed via upstream by ESMValGroup/ESMValTool#3768 and ESMValGroup/ESMValTool#3755
Changes tested upstream and plugged in
v2.11.x
branch via ESMValGroup/ESMValTool#3770Pandas pinned (hopefully for the last time, upstream ESMValCore fix is now in ESMValGroup/ESMValCore#2529)
Also pinned to Python<3.12 just to be as close as the tested ESMValTool 2.11