-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PR 437 to fix https://github.com/RoboStack/ros-humble/issues/33 #31
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
/cc @traversaro |
…nda-forge-pinning 2022.12.15.19.46.12
I am currently far from keyboard, but if I recall correctly in the case of Windows if a symlink is problematic the dll is simply copied. Not installing the unversioned version will fail at runtime I am afraid. To double check we can see how all other plugins are dealt with. |
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
The unversioned version is still being installed via a copy. I think having both copy + symlink led to issues. According to the logs, both dlls (unversioned and versioned) are found properly now by conda-build, whereas the previous build had a 0-byte unversioned dll that caused issues. |
Ok, great! |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)See RoboStack/ros-humble#33: