Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR 437 to fix https://github.com/RoboStack/ros-humble/issues/33 #31

Merged
merged 4 commits into from
Dec 15, 2022

Conversation

Tobias-Fischer
Copy link
Contributor

@Tobias-Fischer Tobias-Fischer commented Dec 15, 2022

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

See RoboStack/ros-humble#33:

RuntimeError: copy_symlink: The file or directory is not a reparse point.: 
"C:\Users\runneradmin\conda_pkgs_dir\libignition-physics5-5.2.0-hef61a30_2\Library\lib\ign-physics-5\engine-plugins\ignition-physics-bullet-plugin.dll", 
"C:\bld\ros-humble-ros-gz-sim-0_1671085464153\_h_env\Library\lib\ign-physics-5\engine-plugins\ignition-physics-bullet-plugin.dll"

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@Tobias-Fischer Tobias-Fischer changed the title Add 437 to fix https://github.com/RoboStack/ros-humble/issues/33 Add PR 437 to fix https://github.com/RoboStack/ros-humble/issues/33 Dec 15, 2022
@Tobias-Fischer
Copy link
Contributor Author

@conda-forge-admin, please rerender

@Tobias-Fischer
Copy link
Contributor Author

/cc @traversaro

@Tobias-Fischer Tobias-Fischer added the automerge Merge the PR when CI passes label Dec 15, 2022
@traversaro
Copy link
Contributor

I am currently far from keyboard, but if I recall correctly in the case of Windows if a symlink is problematic the dll is simply copied. Not installing the unversioned version will fail at runtime I am afraid. To double check we can see how all other plugins are dealt with.

@github-actions github-actions bot merged commit 19116d1 into conda-forge:main Dec 15, 2022
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@Tobias-Fischer
Copy link
Contributor Author

The unversioned version is still being installed via a copy. I think having both copy + symlink led to issues. According to the logs, both dlls (unversioned and versioned) are found properly now by conda-build, whereas the previous build had a 0-byte unversioned dll that caused issues.

@traversaro
Copy link
Contributor

The unversioned version is still being installed via a copy. I think having both copy + symlink led to issues. According to the logs, both dlls (unversioned and versioned) are found properly now by conda-build, whereas the previous build had a 0-byte unversioned dll that caused issues.

Ok, great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants