Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport patches for full Windows support #13

Merged
merged 9 commits into from
Dec 2, 2021

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Nov 29, 2021

Backport gazebosim/gz-tools#73 .

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

@traversaro traversaro changed the title Backport patch for full Windows support Backport patches for full Windows support Nov 29, 2021
@Tobias-Fischer
Copy link
Contributor

Seems like the ignition-tools-backward.lib is not being created / installed?

@traversaro
Copy link
Contributor Author

Seems like the ignition-tools-backward.lib is not being created / installed?

I think that is ok, we can skip the test.

@traversaro
Copy link
Contributor Author

Seems like the ignition-tools-backward.lib is not being created / installed?

I think that is ok, we can skip the test.

Actually I am not sure how much this is ok, but as long as it silence the warning, it is probably a good first step.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro traversaro added the automerge Merge the PR when CI passes label Dec 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2021

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • travis: passed
  • azure: failed

Thus the PR was not passing and not merged.

@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Dec 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2021

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@traversaro traversaro merged commit 6bb9d6f into conda-forge:master Dec 2, 2021
@traversaro traversaro deleted the traversaro-patch-1 branch December 2, 2021 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants