Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rerender with new GL dependency management #50

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I've started rerendering the recipe as instructed in #49.

If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!

Here's a checklist to do before merging.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

Comment on lines -49 to +51
- {{ pin_compatible('occt', exact=True) }}
- {{ pin_compatible('vtk', max_pin='x.x') }}
- {{ pin_compatible('occt', max_pin='x.x.x') }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinning occt to exact will give you trouble when a new build number of occt comes out, our infrastructure won't retrigger your build.

Let vtk manage its own pinning with run exports.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ocp is a bindings project for occt. The bindings code is typically tied to an exact version of occt, so we have to wait for the bindings to be (semi-manually) generated before we can release a new ocp conda package.

Would you still recommend against an exact pin in this case?

@hmaarrfk hmaarrfk changed the title MNT: rerender rerender with new GL dependency management Aug 28, 2024
@hmaarrfk hmaarrfk marked this pull request as draft August 28, 2024 03:33
@hmaarrfk
Copy link

@conda-forge-admin please rerender

@hmaarrfk hmaarrfk marked this pull request as ready for review August 28, 2024 06:41
@hmaarrfk
Copy link

i'm not sure if it makes a difference but one found vtk - osmeta, the other found vtk - qt.

vtk - qt failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants