Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update feedstock to match PyNE conda build #83

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

bquan0
Copy link

@bquan0 bquan0 commented Aug 5, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Now that PyNE has a working conda build, this PR will update the PyNE feedstock so that the updated PyNE version can be installed from conda. Changes include:

  • replacing nose with pytest
  • adding DAGMC as a dependency that PyNE can be installed with
  • updating the github source to the develop branch
  • adding dependencies that PyNE needs (according to the conda build in PyNE)

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [73]
  • This recipe is using a compiler, which now requires adding a build dependence on {{ stdlib("c") }} as well. Note that this rule applies to each output of the recipe using a compiler. For further details, please see META: {{ stdlib("c") }} migration conda-forge.github.io#2102.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@gonuke
Copy link
Contributor

gonuke commented Aug 6, 2024

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 2 commits August 6, 2024 00:43
@bquan0
Copy link
Author

bquan0 commented Aug 6, 2024

@conda-forge-admin, please rerender

@gonuke
Copy link
Contributor

gonuke commented Aug 6, 2024

As far as I can tell, this seems to be failing with the way that nuc_data_make is being called. I can't tell why, but it might be interesting to take that out of the build script just to see if it makes things work?

Notably, we used to explicitly call the python interpretter - maybe we should still?

${PYTHON} ${PREFIX}/bin/nuc_data_make

recipe/build.sh Outdated
Comment on lines 20 to 19
export LD_LIBRARY_PATH="${LD_LIBRARY_PATH}:${PREFIX}/lib"
${PYTHON} ${PREFIX}/bin/nuc_data_make
cd ${HOME}
nuc_data_make
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is where things are failing right now. Not sure why and/or if we need to do it the old way?

@gonuke
Copy link
Contributor

gonuke commented Aug 7, 2024

I see you haven't yet updated the dependency list in the meta.yml. You did a bunch of work in pyne/pyne to get those right, but they aren't included here. It's currently failing on progress but maybe there will be others.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

@bquan0 bquan0 changed the title add dagmc, change github source, change nose to pytest Update feedstock to match PyNE conda build Aug 7, 2024
@bquan0
Copy link
Author

bquan0 commented Aug 7, 2024

@conda-forge-admin, please rerender

Copy link

github-actions bot commented Aug 7, 2024

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/pyne-feedstock/actions/runs/10290124810.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@bquan0
Copy link
Author

bquan0 commented Aug 15, 2024

@conda-forge-admin, please rerender

Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/pyne-feedstock/actions/runs/10409812964.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants