Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REL: pytao v0.4.1 #25

Merged
merged 8 commits into from
Oct 2, 2024
Merged

REL: pytao v0.4.1 #25

merged 8 commits into from
Oct 2, 2024

Conversation

ken-lauer
Copy link
Contributor

@ken-lauer ken-lauer commented Oct 1, 2024

Checklist

@ken-lauer
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Oct 1, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • No valid build backend found for Python recipe for package pytao using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

- test -f $PREFIX/bin/pytao-gui # [unix]
- git clone --depth 1 https://github.com/bmad-sim/bmad-ecosystem bmad
- ACC_ROOT_DIR=$PWD/bmad pytest -v --pyargs pytao.tests
- echo | pytao -lat $PWD/bmad/bmad-doc/tao_examples/erl/lat.bmad
- TAO_REUSE_SUBPROCESS=1 ACC_ROOT_DIR=$PWD/bmad pytest -v --pyargs pytao.tests -k "not help and not test_plot"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explanation of -k "not help and not test_plot":

  • not help - tao.help() interface command test appears to be causing a segfault in the non-subprocess version. This is only on Azure Pipelines runners (i.e., this feedstock). I can't reproduce it locally on MacOS or Linux. Skipping it for now until we can get some more debug details back to Sagan.
  • not test_plot - this is a broad removal of the majority of plotting tests, which are exceedingly slow on Azure Pipelines. The build has been timing out, so this is an arbitrary way to reduce the amount of time spent on tests in the feedstock.

@@ -41,10 +41,12 @@ test:
- pytao.plotting
- pytao.plotting.bokeh
commands:
- echo | pytao --help
# Add back once https://github.com/bmad-sim/pytao/issues/101 is resolved:
# - pytao --help
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ken-lauer ken-lauer marked this pull request as ready for review October 2, 2024 19:22
@ken-lauer ken-lauer merged commit 2f93ea4 into conda-forge:main Oct 2, 2024
3 checks passed
@ken-lauer ken-lauer deleted the rel_v0.4.1 branch October 2, 2024 19:57
@ken-lauer ken-lauer mentioned this pull request Oct 2, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants