Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: depend on gmp instead of mpir #90

Conversation

regro-cf-autotick-bot
Copy link
Contributor

I noticed that this recipe depends on mpir instead of
gmp. The package 'mpir' is deprecated and unmaintained. Use 'gmp' instead.
This PR makes this change.
Notes and instructions for merging this PR:

  1. Make sure that the recipe can indeed only depend on gmp.
  2. Please merge the PR only after the tests have passed.
  3. Feel free to push to the bot's branch to update this PR if needed.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by - please use this URL for debugging.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@xylar xylar mentioned this pull request Sep 2, 2024
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • No valid build backend found for Python recipe for package python-igraph using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@xylar
Copy link
Contributor

xylar commented Sep 3, 2024

@conda-forge-admin, please rerender

@xylar xylar added the automerge Merge the PR when CI passes label Sep 3, 2024
@xylar
Copy link
Contributor

xylar commented Sep 3, 2024

Let's go ahead with this clean-up since #91 likely won't go in for awhile

@@ -13,8 +13,7 @@ source:
sha256: 837f233256c3319f2a35a6a80d94eafe47b43791ef4c6f9e9871061341ac8e28

build:
number: 0
skip: true # [win and vc<14]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer needed.

@@ -23,4 +23,4 @@ export IGRAPH_CMAKE_EXTRA_ARGS="
-DLAPACK_LIBRARIES=\"${PREFIX}/lib/liblapack${SHLIB_EXT}\"
"

${PYTHON} -m pip install --no-deps --ignore-installed . -vvv
${PYTHON} -m pip install --no-deps --no-build-isolation --ignore-installed . -vvv
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit of extra safety (so pip doesn't try to install build deps).

@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Sep 3, 2024
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@xylar xylar added the automerge Merge the PR when CI passes label Sep 3, 2024
@github-actions github-actions bot merged commit b9fa96d into conda-forge:main Sep 3, 2024
26 checks passed
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@regro-cf-autotick-bot regro-cf-autotick-bot deleted the mpir-to-gmp-migration-0_h9e3828 branch September 3, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants