Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin pandas <2.1 #8

Merged
merged 1 commit into from
Sep 19, 2023
Merged

pin pandas <2.1 #8

merged 1 commit into from
Sep 19, 2023

Conversation

orbeckst
Copy link
Contributor

@orbeckst orbeckst commented Sep 18, 2023

Code has some incompatibilities with pandas >= 2.1. This is a temporary fix to pin the package dependency to pandas <2.1.

See also MDAnalysis/solvation-analysis#93

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Code has some incompatibilities with pandas >= 2.1. 
This is a temporary fix to pin the package dependency to
pandas <2.1.

See also MDAnalysis/solvation-analysis#93
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@orbeckst
Copy link
Contributor Author

@conda-forge-admin, please rerender

@github-actions
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/solvation_analysis-feedstock/actions/runs/6225495168.

@orbeckst
Copy link
Contributor Author

@IAlibay please feel free to comment, too.

Properly fixing MDAnalysis/solvation-analysis#93 is undoubtedly the right way forward but until then at least the package should be pulling correct dependencies, and that's a simple fix.

@orbeckst
Copy link
Contributor Author

@orionarcher could you please look at this PR? It might allow us to move forward with the MDAKit MDAnalysis/MDAKits#67 .

@hmacdope hmacdope merged commit d012776 into conda-forge:main Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants