Add conflowgen #18124

1kastner · 2022-02-22T11:12:09Z

Checklist

Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
License file is packaged (see here for an example).
Source is from official source.
Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
If static libraries are linked in, the license of the static library is packaged.
Build number is 0.
A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
When in trouble, please check our knowledge base documentation before pinging a team.

conda-forge-linter · 2022-02-22T11:12:25Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/conflowgen) and found some lint.

Here's what I've got...

For recipes/conflowgen:

noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.
noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

conda-forge-linter · 2022-02-22T11:23:48Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/conflowgen) and found some lint.

Here's what I've got...

For recipes/conflowgen:

requirements: host: python >= 3.8 should not contain a space between relational operator and the version, i.e. python >=3.8
requirements: run: python >= 3.8 should not contain a space between relational operator and the version, i.e. python >=3.8

See https://docs.conda.io/projects/conda-build/en/latest/resources/define-metadata.html#run why I was misled before

conda-forge-linter · 2022-02-22T11:27:04Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/conflowgen) and found some lint.

Here's what I've got...

For recipes/conflowgen:

requirements: host: python>=3.8 must contain a space between the name and the pin, i.e. python >=3.8
requirements: run: python>=3.8 must contain a space between the name and the pin, i.e. python >=3.8
noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

conda-forge-linter · 2022-02-22T13:39:11Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/conflowgen) and found it was in an excellent condition.

It works locally when using `conda-build -c conda-forge -c domdfcoding ./recipes/conflowgen`, hopefully soon there will be clarification at domdfcoding/enum_tools#59 regarding the channel

Currently, not all of the tests are also shipped with the pip release. This will change soon. Then the pyargs approach [1] can be used as well. [1] https://docs.pytest.org/en/latest/explanation/goodpractices.html#tests-as-part-of-application-code

1kastner · 2022-02-22T20:12:12Z

The PR is on hold as long as enum_tools is not on conda-forge. It is on pip as well as on the personal channel of domdfcoding though and the author is working on it - thanks a lot to him!

conda-forge-linter · 2022-02-23T08:57:40Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/conflowgen) and found some lint.

Here's what I've got...

For recipes/conflowgen:

requirements: run: pandas >= 1 should not contain a space between relational operator and the version, i.e. pandas >=1

conda-forge-linter · 2022-02-23T09:03:24Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/conflowgen) and found it was in an excellent condition.

conda-forge-linter · 2022-02-25T16:05:02Z

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but couldn't find any.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

conda-forge-linter · 2022-03-01T09:25:04Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/conflowgen) and found it was in an excellent condition.

1kastner · 2022-03-14T09:35:51Z

I was trying to run this locally but at the time of working on it, the issue #18127 existed so that I could not check the pipeline locally.

ngam · 2022-04-03T18:53:47Z

@1kastner, the linux error is - - nothing provides requested enum_tools >=0.7

ngam · 2022-04-03T18:57:57Z

Do you want to try to add enum_tools? You can add it here in a separate folder

ngam · 2022-04-03T19:03:36Z

Make a new folder named enum_tools and add this meta.yaml:

{% set name = "enum_tools" %}
{% set version = "0.9.0.post1" %}

package:
  name: {{ name|lower }}
  version: {{ version }}

source:
  url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/enum_tools-{{ version }}.tar.gz
  sha256: e59eb1c16667400b185f8a61ac427029919be2ec48b9ca04aa1b388a42fb14d5

build:
  noarch: python
  script: {{ PYTHON }} -m pip install . -vv
  number: 0

requirements:
  host:
    - pip
    - python >=3.6
  run:
    - pygments >=2.6.1
    - python >=3.6
    - typing-extensions >=3.7.4.3

test:
  imports:
    - enum_tools
  commands:
    - pip check
  requires:
    - pip

about:
  home: https://github.com/domdfcoding/enum_tools
  summary: Tools to expand Python's enum module.
  license: LGPL-3.0
  license_file: LICENSE

extra:
  recipe-maintainers:
    - (your name?)

ngam · 2022-04-03T19:05:18Z

~~But your problem is that we don't have kaleido as well~~ We do have it, see below, so you may need to add that too. Btw your recipe should look like this:

{% set name = "conflowgen" %}
{% set version = "1.0.2" %}

package:
  name: {{ name|lower }}
  version: {{ version }}

source:
  url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/conflowgen-{{ version }}.tar.gz
  sha256: c7c35a8ff153277166fbd052156ee1b83279ec8b3a1b468fc4815a7cff3bc04c

build:
  noarch: python
  script: {{ PYTHON }} -m pip install . -vv
  number: 0

requirements:
  host:
    - pip
    - python
  run:
    - enum-tools
    - kaleido-core
    - python-kaleido
    - matplotlib-base
    - numpy
    - openpyxl
    - pandas
    - peewee
    - plotly
    - python
    - seaborn

test:
  imports:
    - conflowgen
  commands:
    - pip check
  requires:
    - pip

about:
  home: https://github.com/1kastner/conflowgen
  summary: A generator for synthetic container flows at maritime container terminals with a focus on yard operations
  license: MIT
  license_file: LICENSE

extra:
  recipe-maintainers:
    - (your name)

recipes/conflowgen/meta.yaml

1kastner · 2022-04-04T06:57:09Z

Do you want to try to add enum_tools? You can add it here in a separate folder

The original author of the package was so nice that he said he was going to do so. A bit of discussion can be found at domdfcoding/enum_tools#59. You can see that his package comes with quite some dependencies that need to be moved to conda-forge as well. I am very thankful that @domdfcoding mentioned he would do this step! Several of these packages already exist on his personal Anaconda channel. I am not 100% where this process is at now and how the dependency tree looks in its entirety, I only saw that the PR at #18361 got stuck because of a technical bug. It would be great and very helpful if @domdfcoding could comment on this.

1kastner · 2022-04-06T10:08:22Z

You prepared a different recipe and suggested that I should use yours instead. I guess it was automatically generated by grayskull? You list some of the optional dependencies and this made me thinking - the setup.py file in my repo was not precise enough. I will rework that because the recipe I showed here is what I actually intended to publish.

1kastner · 2022-04-06T14:20:36Z

Just a comment, @ngam, your recipe for enum_tools does not work. I tried it out and there is a dependency on whey which breaks it. Somehow it is missing in the list of dependencies you have. Were yours auto-generated?

domdfcoding · 2022-04-11T10:07:29Z

I'm very sorry for not getting to this sooner. whey should be available on conda-forge now, so it should be possible to create a recipe for enum_tools. Did you have a PR for the recipe already or do you want me to create one?

1kastner · 2022-04-11T11:13:37Z

@domdfcoding I did not create a PR yet because I did not want to interfere with your specific versioning and packaging planning. I saw that you created a very nice collection of many tools with interdependencies. If it suits to your current concept and you have some capacities, I would prefer to leave it in your hands. If I can be of any help, please let me know!

1kastner · 2022-04-11T12:36:13Z

@domdfcoding the following enum_tools recipe worked for me:

{% set name = "enum_tools" %}
{% set version = "0.9.0.post1" %}

package:
  name: {{ name|lower }}
  version: {{ version }}

source:
  url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/enum_tools-{{ version }}.tar.gz
  sha256: e59eb1c16667400b185f8a61ac427029919be2ec48b9ca04aa1b388a42fb14d5

build:
  noarch: python
  script: {{ PYTHON }} -m pip install . -vv
  number: 0

requirements:
  host:
    - pip
    - python >=3.6
    - setuptools
    - whey
  run:
    - pygments >=2.6.1
    - python >=3.6
    - typing-extensions >=3.7.4.3

test:
  imports:
    - enum_tools
  commands:
    - pip check
  requires:
    - pip

about:
  home: https://github.com/domdfcoding/enum_tools
  summary: Tools to expand Python's enum module.
  license: LGPL-3.0
  license_file: LICENSE

extra:
  recipe-maintainers:
    - XXX

But I guess it is easier for you to adjust to new circumstances as your modules evolve.

1kastner · 2022-04-11T12:53:53Z

With #18645, it should be solved very quickly!

conda-forge-linter · 2022-04-14T07:13:02Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/sarsen, recipes/xarray-sentinel) and found some lint.

Here's what I've got...

For recipes/sarsen:

Feedstock with the same name exists in conda-forge.

For recipes/xarray-sentinel:

Feedstock with the same name exists in conda-forge.

conda-forge-linter · 2022-04-14T07:15:53Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/conflowgen) and found it was in an excellent condition.

1kastner · 2022-04-14T07:41:43Z

@ngam thank you for your patience. Now it is done! Finally this is ready to merge!

ngam

This looks perfect. Unfortunately, I don't have merge rights here, but my unofficial review may accelerate an official review and merge!

ngam · 2022-04-15T02:41:59Z

@conda-forge/staged-recipes this is ready, thank you!

ngam · 2022-04-15T02:43:59Z

@BastianZim nice job on those labels!!! (Love the colors too)

ngam · 2022-04-15T02:45:24Z

@conda-forge/help-python ready for review (adding to see if we have a python label)

1kastner · 2022-04-15T08:38:55Z

Thank you @ngam for the review and support!

ocefpaf · 2022-04-19T00:59:37Z

recipes/gi-docgen/meta.yaml

@@ -1,50 +0,0 @@
-{% set name = "gi-docgen" %}


Please rebase or, if that is easier, resubmit your recipe without deleting what was already there. The infrastructure handles this automatically and deleting them manually may cause problems.

I only did this because of the linter statement at #18124 (comment). I will continue as proposed.

Add conflowgen configuration

d5473c9

Move Python version dependency to requirements

dd3ebd4

Remove spaces around operators

b23f926

See https://docs.conda.io/projects/conda-build/en/latest/resources/define-metadata.html#run why I was misled before

Follow suggestions of linter, add dependencies for running tests

7379094

1kastner added 2 commits February 22, 2022 18:24

Make tests pass

d0c4621

It works locally when using `conda-build -c conda-forge -c domdfcoding ./recipes/conflowgen`, hopefully soon there will be clarification at domdfcoding/enum_tools#59 regarding the channel

Use source_files approach

2ffa9c7

Currently, not all of the tests are also shipped with the pip release. This will change soon. Then the pyargs approach [1] can be used as well. [1] https://docs.pytest.org/en/latest/explanation/goodpractices.html#tests-as-part-of-application-code

1kastner added 2 commits February 23, 2022 09:20

Add runtime requirements with version constraints

cc98b36

Reduce test-specific constraints to run time constraints

794ea98

remove gap

c7dedb8

1kastner mentioned this pull request Feb 24, 2022

Publish conflowgen to conda-forge 1kastner/conflowgen#114

Closed

1kastner added 2 commits February 25, 2022 15:05

Use v1.0.2

18ea458

Fix name, update hash

8bde4ee

Merge branch 'conda-forge:main' into main

7652bfe

drop maintainer

38b2d4a

ngam suggested changes Apr 3, 2022

View reviewed changes

recipes/conflowgen/meta.yaml Show resolved Hide resolved

recipes/conflowgen/meta.yaml Show resolved Hide resolved

recipes/conflowgen/meta.yaml Show resolved Hide resolved

1kastner added 2 commits April 6, 2022 09:15

Merge branch 'conda-forge:main' into main

272cc12

Add pip check as suggested by ngam

f05213b

1kastner mentioned this pull request Apr 6, 2022

Publish enum_tools at conda-forge? domdfcoding/enum_tools#59

Closed

1kastner added 3 commits April 11, 2022 14:37

Fix imports (use 1.0.3 instead)

5058fe9

Merge branch 'conda-forge:main' into main

4e7146e

Merge branch 'main' of github.com:mls-tuhh/staged-recipes

ee5a800

1kastner closed this Apr 14, 2022

1kastner reopened this Apr 14, 2022

Add pip requirement for test

f4c6ed9

1kastner added 3 commits April 14, 2022 09:15

Delete recipes/gi-docgen directory

f05996a

Delete recipes/numix-icon-theme directory

c6daa77

Delete recipes/seclea_ai directory

121310a

ngam approved these changes Apr 15, 2022

View reviewed changes

github-actions bot added review-requested staged-recipes labels Apr 15, 2022

ocefpaf reviewed Apr 19, 2022

View reviewed changes

1kastner mentioned this pull request Apr 19, 2022

Add conflowgen #18702

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add conflowgen #18124

Add conflowgen #18124

1kastner commented Feb 22, 2022 •

edited

Loading

conda-forge-linter commented Feb 22, 2022

conda-forge-linter commented Feb 22, 2022

conda-forge-linter commented Feb 22, 2022

conda-forge-linter commented Feb 22, 2022

1kastner commented Feb 22, 2022 •

edited

Loading

conda-forge-linter commented Feb 23, 2022

conda-forge-linter commented Feb 23, 2022

conda-forge-linter commented Feb 25, 2022

conda-forge-linter commented Mar 1, 2022

1kastner commented Mar 14, 2022 •

edited

Loading

ngam commented Apr 3, 2022

ngam commented Apr 3, 2022

ngam commented Apr 3, 2022

ngam commented Apr 3, 2022 •

edited

Loading

1kastner commented Apr 4, 2022

1kastner commented Apr 6, 2022

1kastner commented Apr 6, 2022

domdfcoding commented Apr 11, 2022

1kastner commented Apr 11, 2022

1kastner commented Apr 11, 2022

1kastner commented Apr 11, 2022

conda-forge-linter commented Apr 14, 2022

conda-forge-linter commented Apr 14, 2022

1kastner commented Apr 14, 2022

ngam left a comment

ngam commented Apr 15, 2022

ngam commented Apr 15, 2022

ngam commented Apr 15, 2022 •

edited

Loading

1kastner commented Apr 15, 2022

ocefpaf Apr 19, 2022

1kastner Apr 19, 2022

Add conflowgen #18124

Add conflowgen #18124

Conversation

1kastner commented Feb 22, 2022 • edited Loading

conda-forge-linter commented Feb 22, 2022

conda-forge-linter commented Feb 22, 2022

conda-forge-linter commented Feb 22, 2022

conda-forge-linter commented Feb 22, 2022

1kastner commented Feb 22, 2022 • edited Loading

conda-forge-linter commented Feb 23, 2022

conda-forge-linter commented Feb 23, 2022

conda-forge-linter commented Feb 25, 2022

conda-forge-linter commented Mar 1, 2022

1kastner commented Mar 14, 2022 • edited Loading

ngam commented Apr 3, 2022

ngam commented Apr 3, 2022

ngam commented Apr 3, 2022

ngam commented Apr 3, 2022 • edited Loading

1kastner commented Apr 4, 2022

1kastner commented Apr 6, 2022

1kastner commented Apr 6, 2022

domdfcoding commented Apr 11, 2022

1kastner commented Apr 11, 2022

1kastner commented Apr 11, 2022

1kastner commented Apr 11, 2022

conda-forge-linter commented Apr 14, 2022

conda-forge-linter commented Apr 14, 2022

1kastner commented Apr 14, 2022

ngam left a comment

Choose a reason for hiding this comment

ngam commented Apr 15, 2022

ngam commented Apr 15, 2022

ngam commented Apr 15, 2022 • edited Loading

1kastner commented Apr 15, 2022

ocefpaf Apr 19, 2022

Choose a reason for hiding this comment

1kastner Apr 19, 2022

Choose a reason for hiding this comment

1kastner commented Feb 22, 2022 •

edited

Loading

1kastner commented Feb 22, 2022 •

edited

Loading

1kastner commented Mar 14, 2022 •

edited

Loading

ngam commented Apr 3, 2022 •

edited

Loading

ngam commented Apr 15, 2022 •

edited

Loading