-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tinycbor c++ library package #21900
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/tinycbor:
|
Hi friend! We really, really, really appreciate that you have taken the time to make a PR on In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on Cheers and thank you for contributing to this community effort! |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/tinycbor:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/tinycbor:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/help-c-cpp, ready for review! |
@conda-forge/help-c-cpp, ready for review! |
recipes/tinycbor/meta.yaml
Outdated
- 0002-Fix-static_assert-compiler-support.patch | ||
|
||
build: | ||
# Uncomment the following line if the package is pure Python and the recipe is exactly the same for all platforms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove all the explainer comments if you're done with them. The comments are still available in the reference recipe.
Subject: [PATCH 2/2] Fix static_assert compiler support | ||
|
||
--- | ||
src/compilersupport_p.h | 2 +- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you opened a pull request to upstream this patch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just opened intel/tinycbor#242
@@ -0,0 +1,209 @@ | |||
From e0fcc34f29633e8d4213581ad1c40575f9d2a0f1 Mon Sep 17 00:00:00 2001 | |||
From: Samuel Debionne <[email protected]> | |||
Date: Wed, 23 Aug 2023 16:13:36 +0200 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you opened a PR to upstream this patch? Does this CMake build system generate artifacts that are named the same as the ones generated by makefiles? For example, sometimes the DLL name on windows might have/not have the lib prefix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure the original build system supports Windows, I'll need to check.
Thank you for the thorough review (nice to get a review from a synchrotron colleague BTW). I applied the necessary changes. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/tinycbor:
|
Sorry about the wait. Somehow the review-requested tag wasn't added, so I haven't been seing this PR in the list. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if build passes. Just be aware that if the custom CMake script if not ABI compatible with upstream's build scripts, you may get complaints from users about compatability with other conda channels. Compatability with other channels is not something we support, but it's good to have artifacts which match the canonical ones.
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).