Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tinycbor c++ library package #21900

Merged
merged 22 commits into from
May 14, 2024
Merged

Conversation

sdebionne
Copy link
Contributor

@sdebionne sdebionne commented Jan 30, 2023

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/tinycbor) and found some lint.

Here's what I've got...

For recipes/tinycbor:

  • The recipe must have some tests.

@sdebionne sdebionne changed the title Add tinycborg c++ library package Add tinycbor c++ library package Jan 30, 2023
@stale
Copy link

stale bot commented Jul 22, 2023

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on main so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

@stale stale bot added stale will be closed in 30 days and removed stale will be closed in 30 days labels Jul 22, 2023
@sdebionne
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/tinycbor) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/tinycbor) and found some lint.

Here's what I've got...

For recipes/tinycbor:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [52, 57]

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/tinycbor) and found some lint.

Here's what I've got...

For recipes/tinycbor:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [52, 58]

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/tinycbor) and found it was in an excellent condition.

@sdebionne
Copy link
Contributor Author

@conda-forge/help-c-cpp, ready for review!

@sdebionne
Copy link
Contributor Author

@conda-forge/help-c-cpp, ready for review!

recipes/tinycbor/build.sh Outdated Show resolved Hide resolved
- 0002-Fix-static_assert-compiler-support.patch

build:
# Uncomment the following line if the package is pure Python and the recipe is exactly the same for all platforms.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all the explainer comments if you're done with them. The comments are still available in the reference recipe.

recipes/tinycbor/meta.yaml Show resolved Hide resolved
recipes/tinycbor/LICENSE Outdated Show resolved Hide resolved
Subject: [PATCH 2/2] Fix static_assert compiler support

---
src/compilersupport_p.h | 2 +-
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you opened a pull request to upstream this patch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just opened intel/tinycbor#242

@@ -0,0 +1,209 @@
From e0fcc34f29633e8d4213581ad1c40575f9d2a0f1 Mon Sep 17 00:00:00 2001
From: Samuel Debionne <[email protected]>
Date: Wed, 23 Aug 2023 16:13:36 +0200
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you opened a PR to upstream this patch? Does this CMake build system generate artifacts that are named the same as the ones generated by makefiles? For example, sometimes the DLL name on windows might have/not have the lib prefix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure the original build system supports Windows, I'll need to check.

@sdebionne
Copy link
Contributor Author

sdebionne commented Oct 5, 2023

Thank you for the thorough review (nice to get a review from a synchrotron colleague BTW). I applied the necessary changes.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/tinycbor) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/tinycbor:

@carterbox
Copy link
Member

Sorry about the wait. Somehow the review-requested tag wasn't added, so I haven't been seing this PR in the list.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/tinycbor) and found it was in an excellent condition.

Copy link
Member

@carterbox carterbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if build passes. Just be aware that if the custom CMake script if not ABI compatible with upstream's build scripts, you may get complaints from users about compatability with other conda channels. Compatability with other channels is not something we support, but it's good to have artifacts which match the canonical ones.

@carterbox carterbox merged commit c58e7df into conda-forge:main May 14, 2024
5 checks passed
@sdebionne sdebionne deleted the tinycbor branch May 15, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants