Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python-pcl #22434

Merged
merged 2 commits into from
Apr 29, 2023
Merged

Add python-pcl #22434

merged 2 commits into from
Apr 29, 2023

Conversation

Tobias-Fischer
Copy link
Contributor

@Tobias-Fischer Tobias-Fischer commented Mar 30, 2023

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/python-pcl) and found it was in an excellent condition.

@Tobias-Fischer
Copy link
Contributor Author

Tobias-Fischer commented Mar 30, 2023

Hi @conda-forge/help-python-c, this is ready for review.

A few notes:

  • The package is not officially maintained anymore (New maintainer(s) sought strawlab/python-pcl#395). Hence there are quite a few patches with basically all of them stemming from the Debian package (except for the last one that adds conda-forge include directories).
  • The package is a RC, but as it's not officially maintained anymore, the best we can get our hands on. It has been shipped in Debian (https://packages.debian.org/sid/python3-pcl).
  • I have skipped Windows as the Debian patches only take care of the Unix side of things. I don't think it's impossible to fix, but I have little interest in Windows and can open an issue in the feedstock once it exists to keep track of it (@traversaro, do you have a use case/interest? No worries if not.)

@traversaro
Copy link
Contributor

traversaro commented Mar 31, 2023

  • (@traversaro, do you have a use case/interest? No worries if not.)

Cool, I did not even know about this, and it could indeed be useful. Anyhow, no one on our side is using it, and given that it is not currently mantained I am not interested in using it.

@Tobias-Fischer
Copy link
Contributor Author

Kind reminder @conda-forge/help-python-c @wolfv

@Tobias-Fischer
Copy link
Contributor Author

Another ping @conda-forge/help-python-c @wolfv

@Tobias-Fischer
Copy link
Contributor Author

Another friendly ping @conda-forge/staged-recipes :)

@wolfv wolfv merged commit 1756533 into conda-forge:main Apr 29, 2023
@Tobias-Fischer Tobias-Fischer deleted the add-python-pcl branch April 29, 2023 20:25
@Tobias-Fischer
Copy link
Contributor Author

Thanks @wolfv!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants