Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kernel-tuner and python-constraint2 #24420

Merged
merged 7 commits into from
Dec 8, 2023

Conversation

bouweandela
Copy link
Contributor

@bouweandela bouweandela commented Nov 3, 2023

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/kernel-tuner, recipes/python-constraint2) and found some lint.

Here's what I've got...

For recipes/python-constraint2:

  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/kernel-tuner, recipes/python-constraint2) and found it was in an excellent condition.

@bouweandela
Copy link
Contributor Author

@benvanwerkhoven @fjwillemsen @isazi Please comment here to indicate whether or not you would like to be a maintainer of these conda-forge packages. For a start, I added you based on your activity in the respective GitHub repositories, but please let me know if I should make changes.

It would also be great if you could have a quick look at the recipes and check for any obvious mistakes.

@benvanwerkhoven
Copy link

Hi Bouwe! Thanks a lot for setting this up! I would like to be one of the maintainers indeed. Best, Ben

@bouweandela
Copy link
Contributor Author

I would like to be one of the maintainers indeed.

@benvanwerkhoven Great! Just for kernel-tuner, or also for the python-constraint2 package?

@bouweandela bouweandela changed the title Add kernel-tuner and python-constraints2 Add kernel-tuner and python-constraint2 Nov 6, 2023
@benvanwerkhoven
Copy link

For Kernel Tuner indeed, @fjwillemsen would be the best contactperson for python-constraint2

@fjwillemsen
Copy link

I would indeed like to be maintainer on both packages, and contact person for python-constraint2.

@isazi
Copy link

isazi commented Nov 9, 2023

I also agree to be a maintainer for the package.

@bouweandela bouweandela marked this pull request as ready for review November 9, 2023 16:20
@bouweandela
Copy link
Contributor Author

@conda-forge-admin, please ping conda-forge/help-python-c

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/help-python-c and so here I am doing that.

@bouweandela
Copy link
Contributor Author

Thanks bot! @conda-forge/help-python-c: this is ready for review.

build:
script: {{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolation
number: 0
skip: True # [win or py>311]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it can be noarch

Suggested change
skip: True # [win or py>311]
noarch: python

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried that initially but the tests fail on Windows (see 580d294 and here), so after discussing with the authors of the package in KernelTuner/kernel_tuner#128 (comment), I disabled the windows build to avoid disappointing Windows users by allowing them to install something that doesn't work. Is this the right way to do it? Or can we make the package noarch: python but still skip the Windows build?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can make it noarch: python but add a run dependency on __unix. That would avoid building the package for every Python/OS combination.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this as suggested in 52be0d1, but now the windows build is failing again. Did I miss something?

@@ -0,0 +1,56 @@
{% set name = "python-constraint2" %}
{% set version = "2.0.0b4" %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We prefer to have releases on conda-forge, can you please submit one of these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if I understand the comment, my apologies. Do you mean a release that is not a beta version?

If the issue is indeed that it is a beta release, the reason for doing it like this is the following: version 0.x of kernel tuner does not include the source distribution on PyPI, so that is I why I opted for building the conda-forge package for version 1.x. However, that requires python-constraint2 which is only available as a beta version, I suspect this is because maintenance was recently taken up again by a new maintainer, @fjwillemsen.

@bouweandela
Copy link
Contributor Author

Thank you for taking the time to review this @xhochy! 🥳

@xhochy xhochy merged commit 836d00b into conda-forge:main Dec 8, 2023
3 of 5 checks passed
@bouweandela bouweandela deleted the kernel_tuner branch December 9, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants