-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kernel-tuner and python-constraint2 #24420
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/python-constraint2:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@benvanwerkhoven @fjwillemsen @isazi Please comment here to indicate whether or not you would like to be a maintainer of these conda-forge packages. For a start, I added you based on your activity in the respective GitHub repositories, but please let me know if I should make changes. It would also be great if you could have a quick look at the recipes and check for any obvious mistakes. |
Hi Bouwe! Thanks a lot for setting this up! I would like to be one of the maintainers indeed. Best, Ben |
@benvanwerkhoven Great! Just for kernel-tuner, or also for the |
For Kernel Tuner indeed, @fjwillemsen would be the best contactperson for python-constraint2 |
I would indeed like to be maintainer on both packages, and contact person for python-constraint2. |
I also agree to be a maintainer for the package. |
@conda-forge-admin, please ping conda-forge/help-python-c |
Hi! This is the friendly automated conda-forge-webservice. I was asked to ping @conda-forge/help-python-c and so here I am doing that. |
Thanks bot! @conda-forge/help-python-c: this is ready for review. |
recipes/kernel-tuner/meta.yaml
Outdated
build: | ||
script: {{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolation | ||
number: 0 | ||
skip: True # [win or py>311] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it can be noarch
skip: True # [win or py>311] | |
noarch: python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried that initially but the tests fail on Windows (see 580d294 and here), so after discussing with the authors of the package in KernelTuner/kernel_tuner#128 (comment), I disabled the windows build to avoid disappointing Windows users by allowing them to install something that doesn't work. Is this the right way to do it? Or can we make the package noarch: python
but still skip the Windows build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can make it noarch: python
but add a run
dependency on __unix
. That would avoid building the package for every Python/OS combination.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed this as suggested in 52be0d1, but now the windows build is failing again. Did I miss something?
@@ -0,0 +1,56 @@ | |||
{% set name = "python-constraint2" %} | |||
{% set version = "2.0.0b4" %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We prefer to have releases on conda-forge, can you please submit one of these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if I understand the comment, my apologies. Do you mean a release that is not a beta version?
If the issue is indeed that it is a beta release, the reason for doing it like this is the following: version 0.x of kernel tuner does not include the source distribution on PyPI, so that is I why I opted for building the conda-forge package for version 1.x. However, that requires python-constraint2
which is only available as a beta version, I suspect this is because maintenance was recently taken up again by a new maintainer, @fjwillemsen.
Thank you for taking the time to review this @xhochy! 🥳 |
Checklist
If static libraries are linked in, the license of the static library is packaged.url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).When in trouble, please check our knowledge base documentation before pinging a team.