Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python-mumps from pypi #25042

Merged
merged 11 commits into from
Jan 30, 2024
Merged

Add python-mumps from pypi #25042

merged 11 commits into from
Jan 30, 2024

Conversation

akhmerov
Copy link
Contributor

@akhmerov akhmerov commented Jan 15, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (python-mumps) and found some lint.

Here's what I've got...

For python-mumps:

  • Please do not delete the example recipe found in recipes/example/meta.yaml.
  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (python-mumps) and found some lint.

Here's what I've got...

For python-mumps:

  • Please do not delete the example recipe found in recipes/example/meta.yaml.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/python-mumps) and found it was in an excellent condition.

@akhmerov
Copy link
Contributor Author

@conda-forge/help-python-c I believe this is ready. Some remarks:

  • I've skipped the windows build due to an upstream bug, which will hopefully be fixed soon.
  • Not sure why python 3.12 isn't built.

@akhmerov
Copy link
Contributor Author

Extra information:

  • The recipe was prepared with grayskull with minimal post-processing below
  • Adding binary requirements to build: numpy, mumps, python, compilers.
  • Skipping windows builds and pinning library versions due to already reported bugs in mumps and metis feedstocks.

@akhmerov akhmerov changed the title add a recipe for python-mumps Add python-mumps from pypi Jan 16, 2024
@akhmerov
Copy link
Contributor Author

akhmerov commented Jan 18, 2024

The failures are due to conda-forge/mumps-feedstock#106; I'll fix these as soon as the upstream issue is fixed.

recipes/python-mumps/meta.yaml Outdated Show resolved Hide resolved
recipes/python-mumps/meta.yaml Outdated Show resolved Hide resolved
recipes/python-mumps/meta.yaml Outdated Show resolved Hide resolved
recipes/python-mumps/meta.yaml Outdated Show resolved Hide resolved
@akhmerov
Copy link
Contributor Author

@xhochy thank you for the review! Should be good to go now.

@akhmerov akhmerov requested a review from xhochy January 19, 2024 23:44
@xhochy xhochy merged commit 4cd9e85 into conda-forge:main Jan 30, 2024
5 checks passed
@akhmerov akhmerov deleted the python-mumps branch January 30, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants