Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vulkan-volk #27531

Merged
merged 11 commits into from
Sep 10, 2024
Merged

Add vulkan-volk #27531

merged 11 commits into from
Sep 10, 2024

Conversation

hmaarrfk
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/vulkan-volk/meta.yaml) and found some lint.

Here's what I've got...

For recipes/vulkan-volk/meta.yaml:

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/vulkan-volk/meta.yaml) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/vulkan-volk/meta.yaml) and found some lint.

Here's what I've got...

For recipes/vulkan-volk/meta.yaml:

  • pin_subpackage should be used instead of pin_compatible for vulkan-volk because it is one of the known outputs of this recipe: ['vulkan-volk'].

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/vulkan-volk/meta.yaml) and found it was in an excellent condition.

@hmaarrfk hmaarrfk marked this pull request as ready for review September 10, 2024 02:55
@hmaarrfk
Copy link
Contributor Author

@libvulkan-loader @libvulkan-headers I would appreciate your review here, it seems like this is now a dependency of conda-forge/vulkan-tools-feedstock#8

@hmaarrfk
Copy link
Contributor Author

@conda-forge/vulkan-loader @conda-forge/vulkan-headers

Copy link
Contributor

@traversaro traversaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The recipe seems fine! Just to understand, what is the reason why this needs to be a static library?

@hmaarrfk
Copy link
Contributor Author

The recipe seems fine! Just to understand, what is the reason why this needs to be a static library?

https://github.com/zeux/volk?tab=readme-ov-file#building

This is all i know. I had opened PRs but they seem to include a volk.c inside the volk.h file, so I figured this was likely some super trickery that was being made..... didn't seem safe to deviate too much from upstream.

I had opened PRs zeux/volk#202 zeux/volk#201 but i figured i would use them as intended first, then make recommendations.

@hmaarrfk
Copy link
Contributor Author

Thanks you two, let me know if you want to help maintain downstream by pinging me on the feedstock

@hmaarrfk hmaarrfk merged commit 685c384 into conda-forge:main Sep 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants