-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vulkan-volk #27531
Add vulkan-volk #27531
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/vulkan-volk/meta.yaml:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/vulkan-volk/meta.yaml:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@libvulkan-loader @libvulkan-headers I would appreciate your review here, it seems like this is now a dependency of conda-forge/vulkan-tools-feedstock#8 |
@conda-forge/vulkan-loader @conda-forge/vulkan-headers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The recipe seems fine! Just to understand, what is the reason why this needs to be a static library?
https://github.com/zeux/volk?tab=readme-ov-file#building This is all i know. I had opened PRs but they seem to include a I had opened PRs zeux/volk#202 zeux/volk#201 but i figured i would use them as intended first, then make recommendations. |
Thanks you two, let me know if you want to help maintain downstream by pinging me on the feedstock |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).