Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FANS to conda-forge #28099

Merged
merged 13 commits into from
Dec 12, 2024
Merged

Add FANS to conda-forge #28099

merged 13 commits into from
Dec 12, 2024

Conversation

claudiushaag
Copy link
Contributor

@claudiushaag claudiushaag commented Nov 4, 2024

Hi!

We would love to add our open-source Fourier Accelerated Nodal Solvers, (FANS) to conda-forge.
The package effectively just exposes an executable, FANS.
This is our first contribution, but we were able to build packages locally. We would love some feedback and are exited about adding FANS to the community!

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 4, 2024

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/fans/meta.yaml) and found some lint.

Here's what I've got...

For recipes/fans/meta.yaml:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [12]

@claudiushaag claudiushaag marked this pull request as ready for review November 4, 2024 17:38
Copy link
Contributor

github-actions bot commented Nov 4, 2024

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/fans/meta.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: EMMAOpenSource, sanathkeshav. Please ask them to comment on this PR if they are.

@EMMAOpenSource
Copy link

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

* `recipes/fans/meta.yaml`:
  
  * lints:
    
    * The following maintainers have not yet confirmed that they are willing to be listed here: EMMAOpenSource, sanathkeshav. Please ask them to comment on this PR if they are.

Hi.
I confirm that I am willing to be listed as maintainer.

@sanathkeshav
Copy link

Hello! I confirm that I am willing to be listed as a maintainer too! Thanks!

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/fans/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 5, 2024

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/fans/meta.yaml) and found some lint.

Here's what I've got...

For recipes/fans/meta.yaml:

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/fans/meta.yaml) and found it was in an excellent condition.

@claudiushaag
Copy link
Contributor Author

The build problems here are not apparent using mambabuild locally.
They seem to be addressed here and here
But, mambabuild does not find the stdlib('c'). Thus, now trying to change to rattler-build...

Current local problem: no stdlib found for language c, even though variant_configuration is provided...
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/fans/recipe.yaml) and found some lint.

Here's what I've got...

For recipes/fans/recipe.yaml:

  • The homepage item is expected in the about section.
  • This recipe is using a compiler, which now requires adding a build dependence on ${{ stdlib("c") }} as well. Note that this rule applies to each output of the recipe using a compiler. For further details, please see META: {{ stdlib("c") }} migration conda-forge.github.io#2102.

For recipes/fans/recipe.yaml:

  • Jinja2 variable references are suggested to take a ${{<one space><variable name><one space>}} form. See lines [6, 9].

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/fans/recipe.yaml) and found it was in an excellent condition.

+ because rattler-build does not copy h5?
+ delete other not needed files
@claudiushaag
Copy link
Contributor Author

@conda-forge/help-c-cpp ready for review!

+ add real tests
+ but download h5 file from git directly, as
    rattler-build does not copy it....?
@danielnachun
Copy link
Contributor

danielnachun commented Nov 27, 2024

Can you try enabling macOS here? I believe all of the dependencies are available, though I realize MPI is not terribly useful on a single macOS machine. However, there is still value for users to able to do simple local tests. OpenMPI support on Windows is lacking conda-forge at the moment so skipping that OS is understandable.

@claudiushaag
Copy link
Contributor Author

@danielnachun Thank you for having a look at this!
Currently, the macOS build does not compile for us locally, but we're working on it: DataAnalyticsEngineering/FANS/pull/25
The same is valid for the CI.

My plan was to update that as soon as it is ready.

@claudiushaag
Copy link
Contributor Author

I think this would be ready to merge, would appreciate it!
@conda-forge/help-c-cpp

recipes/fans/recipe.yaml Outdated Show resolved Hide resolved
recipes/fans/recipe.yaml Outdated Show resolved Hide resolved
recipes/fans/recipe.yaml Outdated Show resolved Hide resolved
@claudiushaag claudiushaag requested a review from xhochy December 12, 2024 10:30
@xhochy xhochy merged commit 397a882 into conda-forge:main Dec 12, 2024
7 checks passed
sanathkeshav added a commit to DataAnalyticsEngineering/FANS that referenced this pull request Dec 13, 2024
* Conda installation hints to README.md

Also, refer to conda-forge/staged-recipes#28099

---------

Co-authored-by: Sanath Keshav <[email protected]>
Co-authored-by: Ishaan Desai <[email protected]>
@claudiushaag claudiushaag deleted the fans branch December 20, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants