-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FANS to conda-forge #28099
Add FANS to conda-forge #28099
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/fans/meta.yaml:
|
Hi! This is the staged-recipes linter and I found some lint. File-specific lints and/or hints:
|
Hi. |
Hello! I confirm that I am willing to be listed as a maintainer too! Thanks! |
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/fans/meta.yaml:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Current local problem: no stdlib found for language c, even though variant_configuration is provided...
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/fans/recipe.yaml:
For recipes/fans/recipe.yaml:
|
+ Fix remaining lints
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
+ because rattler-build does not copy h5? + delete other not needed files
@conda-forge/help-c-cpp ready for review! |
+ add real tests + but download h5 file from git directly, as rattler-build does not copy it....?
Can you try enabling macOS here? I believe all of the dependencies are available, though I realize MPI is not terribly useful on a single macOS machine. However, there is still value for users to able to do simple local tests. OpenMPI support on Windows is lacking conda-forge at the moment so skipping that OS is understandable. |
+ add patch for FANS shortcoming
@danielnachun Thank you for having a look at this! My plan was to update that as soon as it is ready. |
I think this would be ready to merge, would appreciate it! |
* Conda installation hints to README.md Also, refer to conda-forge/staged-recipes#28099 --------- Co-authored-by: Sanath Keshav <[email protected]> Co-authored-by: Ishaan Desai <[email protected]>
Hi!
We would love to add our open-source Fourier Accelerated Nodal Solvers, (FANS) to conda-forge.
The package effectively just exposes an executable, FANS.
This is our first contribution, but we were able to build packages locally. We would love some feedback and are exited about adding FANS to the community!
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).