Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nodejs-wheel #28400

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

add nodejs-wheel #28400

wants to merge 4 commits into from

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Nov 28, 2024

For basedpyright #28367

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Signed-off-by: Jinzhe Zeng <[email protected]>
Copy link

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/nodejs-wheel/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/nodejs-wheel/meta.yaml:

  • ℹ️ Jinja2 variable references are suggested to take a {{<one space><variable name><one space>}} form. See lines [18].

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12076674036. Examine the logs at this URL for more detail.

Signed-off-by: Jinzhe Zeng <[email protected]>
Signed-off-by: Jinzhe Zeng <[email protected]>
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/nodejs-wheel/meta.yaml) and found it was in an excellent condition.

Signed-off-by: Jinzhe Zeng <[email protected]>
@njzjz njzjz marked this pull request as ready for review November 29, 2024 00:22
@njzjz
Copy link
Member Author

njzjz commented Nov 29, 2024

@conda-forge/help-nodejs @conda-forge/help-python ready for review. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants