Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add python-abi3 #28743

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Add python-abi3 #28743

merged 3 commits into from
Jan 7, 2025

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Jan 3, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin

This comment was marked as outdated.

Sign in to view
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/python-abi3/meta.yaml) and found it was in an excellent condition.

@isuruf
Copy link
Member Author

isuruf commented Jan 6, 2025

@conda-forge/staged-recipes this is ready for review

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@ocefpaf ocefpaf merged commit ffbbfee into conda-forge:main Jan 7, 2025
7 checks passed
@isuruf
Copy link
Member Author

isuruf commented Jan 7, 2025

Thanks

@isuruf isuruf deleted the abi3 branch January 7, 2025 09:55
h-vetinari
h-vetinari reviewed Jan 7, 2025
View reviewed changes
recipes/python-abi3/bld.bat
FOR %%F IN (activate deactivate) DO (
if not exist %PREFIX%\etc\conda\%%F.d MKDIR %PREFIX%\etc\conda\%%F.d
if errorlevel 1 exit 1
sed "s/@PY_LIMITED_API/%PY_LIMITED_API%/g" %RECIPE_DIR%\scripts\%%F.bat >> %PREFIX%\etc\conda\%%F.d\%PKG_NAME%_%%F.bat
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you forgot to create the bat versions of the activation scripts. This didn't fail here because this call didn't have an if errorlevel.

@h-vetinari h-vetinari mentioned this pull request Jan 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-vetinari h-vetinari h-vetinari left review comments

Assignees
No one assigned
Labels
review-requested staged-recipes
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@isuruf @conda-forge-admin @h-vetinari @ocefpaf