wetterdienst v0.49.0 #70

regro-cf-autotick-bot · 2022-11-28T12:34:23Z

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

Dependencies have been updated if changed: see upstream
Tests have passed
Updated license if changed and license_file is packaged

Information about this PR:

Feel free to push to the bot's branch to update this PR if needed.
The bot will almost always only open one PR per version.
The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.

Packages found by source code inspection but not in the meta.yaml:

plotly
dash-bootstrap-components
fastapi
utm
shapely
pytz
dash
autovizwidget
finesse

Packages found in the meta.yaml but not found by source code inspection:

cachetools
requests-ftp
beautifulsoup4
deprecation
importlib_metadata
dataclass-wizard

_{This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3564554550, please use this URL for debugging.}

conda-forge-linter · 2022-11-28T12:34:28Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

amotl · 2022-11-28T16:09:04Z

It looks like the build is currently failing. Do you have any magic spell, @kmuehlbauer?

  RuntimeError: The Poetry configuration is invalid:
    - Additional properties are not allowed ('group' was unexpected)

It is reasonable to assume it is related to earthobservations/wetterdienst@0920548871d?
Does Poetry need an update? Any way to find out which version is installed on the feedstock CI builders?

-- https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=619285&view=logs&j=656edd35-690f-5c53-9ba3-09c10d0bea97&t=e5c8ab1d-8ff9-5cae-b332-e15ae582ed2d

kmuehlbauer · 2022-11-28T16:22:51Z

@amotl I've no idea, sorry. Also I'm not versed with poetry. I can't imagine what 'group' means in that context.

amotl · 2022-11-28T17:17:20Z

I've no idea, sorry. Also I'm not versed with Poetry.

All right. We will figure it out. Thank you.

I can't imagine what 'group' means in that context.

We recently introduced Poetry dependency groups with earthobservations/wetterdienst@0920548871d, see https://python-poetry.org/docs/managing-dependencies/.

amotl · 2022-11-28T17:31:46Z

I've discovered that others also reported about this, for example at conda-forge/interpolation-feedstock#24 and conda-forge/astral-feedstock#22.

The solution for @albop was to patch the pyproject.toml file to make it compatible with older version of Poetry. @hajapy and @jan-janssen gave the relevant hint that we will have to wait until Poetry 1.2 is available on Conda Forge. It may be right around the corner.

/cc @xylar, @maxbachmann

xylar · 2022-11-28T20:12:58Z

Can you use poetry-core, rather than the full poetry? If so, that would be the easiest solution. We support all releases of poetry core already:
https://github.com/conda-forge/poetry-core-feedstock
Note that the version numbers for poetry-core don't correspond with those for poetry so you would need to find out from the package developer what version of poetry-core is required.

xylar · 2022-11-28T20:14:51Z

Yes, it looks like only poetry-core is required and no version is specified:
https://github.com/earthobservations/wetterdienst/blob/main/pyproject.toml#L365

amotl · 2022-11-28T21:10:37Z

Are you saying the solution would be as easy as #72?

xylar · 2022-11-28T21:23:51Z

@amotl, yes, but I wouldn't do that as a separate PR. Just change it here by editing the file directly on GitHub.

xylar · 2022-11-28T21:32:59Z

Make sure to update the dependencies here to exactly match:
https://github.com/earthobservations/wetterdienst/blob/v0.49.0/pyproject.toml#L98-L125

If you need another maintainer to help out, let me know. You can add me.

amotl · 2022-11-28T21:42:50Z

Make sure to update the dependencies...

I was planning to integrate #71 and #72, and then tell the bot to refresh/re-create the PR somehow. Is it the wrong approach?

If you need another maintainer to help out, let me know. You can add me.

Done with #73/#74. Thank you!

xylar · 2022-11-28T21:47:25Z

I was planning to integrate #71 and #72, and then tell the bot to refresh/re-create the PR somehow. Is it the wrong approach?

It would be more typical and more efficient to do everything as part of updating to v0.49.0 here. It's fine to make changes to the bot's branch for that purpose. It's much clearer that the changes you're making are related to the new version. It also means less churn building new packages that aren't needed (you build a new package every time you merge a PR if you're doing things right).

This may unblock release 0.49.0, because it may provide Poetry 1.2 already, which is needed for serving dependency groups, which got recently introduced into `pyproject.toml` of Wetterdienst.

amotl · 2022-11-28T22:07:00Z

Thank you for your suggestion to use poetry-core. It looks like 2d78af2 fixes the build.

updated v0.49.0

c1cd87a

regro-cf-autotick-bot requested review from amotl, gutzbenj and kmuehlbauer as code owners November 28, 2022 12:34

gutzbenj approved these changes Nov 28, 2022

View reviewed changes

amotl assigned amotl and gutzbenj Nov 28, 2022

This comment was marked as duplicate.

Sign in to view

amotl mentioned this pull request Nov 28, 2022

Use poetry-core instead of poetry #72

Closed

amotl mentioned this pull request Nov 28, 2022

@conda-forge-admin, please add user @xylar #73

Closed

xylar mentioned this pull request Nov 28, 2022

[ci skip] adding user @xylar #74

Merged

Use poetry-core instead of poetry

2d78af2

This may unblock release 0.49.0, because it may provide Poetry 1.2 already, which is needed for serving dependency groups, which got recently introduced into `pyproject.toml` of Wetterdienst.

amotl requested a review from xylar as a code owner November 28, 2022 21:54

amotl approved these changes Nov 28, 2022

View reviewed changes

amotl mentioned this pull request Nov 28, 2022

Update list of runtime dependencies in recipe/meta.yml #71

Closed

amotl merged commit 8785e60 into conda-forge:main Nov 28, 2022

regro-cf-autotick-bot deleted the 0.49.0_h4b56c6 branch November 28, 2022 22:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

wetterdienst v0.49.0 #70

wetterdienst v0.49.0 #70

regro-cf-autotick-bot commented Nov 28, 2022 •

edited by gutzbenj

Loading

conda-forge-linter commented Nov 28, 2022

amotl commented Nov 28, 2022 •

edited

Loading

kmuehlbauer commented Nov 28, 2022

amotl commented Nov 28, 2022 •

edited

Loading

amotl commented Nov 28, 2022 •

edited

Loading

xylar commented Nov 28, 2022

This comment was marked as duplicate.

xylar commented Nov 28, 2022

amotl commented Nov 28, 2022

xylar commented Nov 28, 2022

xylar commented Nov 28, 2022

amotl commented Nov 28, 2022

xylar commented Nov 28, 2022

amotl commented Nov 28, 2022

wetterdienst v0.49.0 #70

wetterdienst v0.49.0 #70

Conversation

regro-cf-autotick-bot commented Nov 28, 2022 • edited by gutzbenj Loading

Dependency Analysis

Packages found by source code inspection but not in the meta.yaml:

Packages found in the meta.yaml but not found by source code inspection:

conda-forge-linter commented Nov 28, 2022

amotl commented Nov 28, 2022 • edited Loading

kmuehlbauer commented Nov 28, 2022

amotl commented Nov 28, 2022 • edited Loading

amotl commented Nov 28, 2022 • edited Loading

xylar commented Nov 28, 2022

This comment was marked as duplicate.

xylar commented Nov 28, 2022

amotl commented Nov 28, 2022

xylar commented Nov 28, 2022

xylar commented Nov 28, 2022

amotl commented Nov 28, 2022

xylar commented Nov 28, 2022

amotl commented Nov 28, 2022

regro-cf-autotick-bot commented Nov 28, 2022 •

edited by gutzbenj

Loading

amotl commented Nov 28, 2022 •

edited

Loading

amotl commented Nov 28, 2022 •

edited

Loading

amotl commented Nov 28, 2022 •

edited

Loading