Fix test warnings (#370)

conda-incubator · Mar 5, 2024 · 7ff007e · 7ff007e
1 parent 6813f75
commit 7ff007e
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 7 deletions.
diff --git a/src/features/environments/components/EnvironmentDropdown.tsx b/src/features/environments/components/EnvironmentDropdown.tsx
@@ -100,8 +100,14 @@ export const EnvironmentDropdown = ({
             }
           >
             <StyledIconButton
-              onClick={e => onCreateNewEnvironmentTab(e, namespace)}
-              disabled={!canCreate}
+              onClick={e =>
+                canCreate && onCreateNewEnvironmentTab(e, namespace)
+              }
+              // Do not use the `disabled` attribute. Disable manually with
+              // JavaScript and the `aria-disabled` attribute, otherwise the
+              // tooltip won't work. More info:
+              // https://github.com/conda-incubator/conda-store-ui/pull/370/files#r1486492450
+              aria-disabled={!canCreate}
             >
               <AddIcon />
             </StyledIconButton>

diff --git a/src/styles/StyledIconButton.tsx b/src/styles/StyledIconButton.tsx
@@ -18,7 +18,7 @@ export const StyledIconButton = styled(Button)(({ theme }) => ({
     outlineWidth: "medium",
     transition: "none"
   },
-  "&:disabled": {
+  '&[aria-disabled="true"]': {
     backgroundColor: theme.palette.secondary[100],
     border: "none",
     color: theme.palette.secondary[300]

diff --git a/test/environmentCreate/CreateEnvironmentPackagesTableRow.test.tsx b/test/environmentCreate/CreateEnvironmentPackagesTableRow.test.tsx
@@ -34,9 +34,13 @@ describe("<CreateEnvironmentPackagesTableRow />", () => {
     return render(
       mockTheme(
         <Provider store={store}>
-          <CreateEnvironmentPackagesTableRow
-            requestedPackage={requestedPackage}
-          />
+          <table>
+            <tbody>
+              <CreateEnvironmentPackagesTableRow
+                requestedPackage={requestedPackage}
+              />
+            </tbody>
+          </table>
         </Provider>
       )
     );

diff --git a/test/environmentDetails/SpecificationEdit.test.tsx b/test/environmentDetails/SpecificationEdit.test.tsx
@@ -70,6 +70,7 @@ describe("<SpecificationEdit />", () => {
           <SpecificationEdit
             descriptionUpdated={false}
             onUpdateEnvironment={jest.fn()}
+            onSpecificationIsChanged={jest.fn()}
           />
         </Provider>
       )

diff --git a/test/requestedPackages/RequestedPackagesTableRow.test.tsx b/test/requestedPackages/RequestedPackagesTableRow.test.tsx
@@ -34,7 +34,11 @@ describe("<RequestedPackagesTableRow />", () => {
     return render(
       mockTheme(
         <Provider store={store}>
-          <RequestedPackagesTableRow requestedPackage={requestedPackage} />
+          <table>
+            <tbody>
+              <RequestedPackagesTableRow requestedPackage={requestedPackage} />
+            </tbody>
+          </table>
         </Provider>
       )
     );