Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logout functionality and improve login/logout design #276

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

steff456
Copy link
Contributor

Fixes #247.

Description

This pull request:

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentaion (if required)?
  • Did you add/update relevant tests for this change (if required)?

Additional information

log.mp4

@steff456 steff456 added type: enhancement 💅🏼 New feature or request high priority 🌋 area: UI design 🎨 Items related to the user interface project: JATIC Work item needed for the JATIC project labels Aug 23, 2023
@steff456 steff456 added this to the 🚀 JATIC - Q1 milestone Aug 23, 2023
@steff456 steff456 requested a review from pierrotsmnrd August 23, 2023 16:33
@steff456 steff456 self-assigned this Aug 23, 2023
Copy link
Contributor

@pierrotsmnrd pierrotsmnrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this PR, with the latest version of conda-store.

  • The login works ✅
  • but the logout doesn't, it keeps me logged in ❌

I have tried with the old ui : I was able to log out, which leads me to think the problem is on the UI side.

@steff456
Copy link
Contributor Author

@pierrotsmnrd can you please upload a video of what you are seeing? The logout is working on my side 🤨

Copy link
Contributor

@pierrotsmnrd pierrotsmnrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, the problem was on my end. I got a CORS error because of a misconfiguration in my conda-store instance.

Good to go ! :)

@pierrotsmnrd pierrotsmnrd merged commit aae1a55 into conda-incubator:main Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: UI design 🎨 Items related to the user interface project: JATIC Work item needed for the JATIC project type: enhancement 💅🏼 New feature or request
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

ENH - Improve log in/out functionality
2 participants