Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links to build artifacts #443

Merged
merged 6 commits into from
Nov 26, 2024
Merged

Conversation

gabalafou
Copy link
Contributor

@gabalafou gabalafou commented Nov 22, 2024

Copy link
Contributor

@soapy1 soapy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this resolves the issue in conda-incubator/conda-store#995!

Calling out, I'm not very familiar with ts at all. Might be worth getting another reviewer?

@gabalafou
Copy link
Contributor Author

Excellent! I was about to add instructions for how to confirm that this works, but you're already ahead of me.

As for not being familiar with TypeScript, I think it's fine. I have made the tests much more comprehensive, so I think we can have confidence that this is working. And so long as the TypeScript checker isn't complaining (and there aren't any casts to any, which there aren't), all should be well in the world.

@gabalafou gabalafou merged commit ee5df16 into conda-incubator:main Nov 26, 2024
6 checks passed
@gabalafou gabalafou deleted the fix-api-url branch November 26, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - getting artifacts from the ui returns not found error
3 participants