-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflows to publish docker container on release #451
Add workflows to publish docker container on release #451
Conversation
b58d9cb
to
5206920
Compare
878177c
to
622c9b7
Compare
Are there any docs that should be updated about publishing this new release artifact? |
7806e64
to
8f9c835
Compare
8f9c835
to
d9b3055
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I'm the right person to review GitHub workflows. I am not familiar enough with workflow files (nor specific workflows such as uploading Docker images) to be able to spot errors.
But I gave this a careful look and left some questions and comments.
tags: | | ||
${{ steps.meta.outputs.tags }} | ||
push: true | ||
labels: ${{ steps.meta.outputs.labels }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the difference between tags and labels?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Labels contain metadata about the image (ref link). Tags denote a version of the image. So like, when you go to pull a docker image the form is docker pull <maybe repo>/<namespace>/<image name>:<tag>
. For the demo published conda-store-ui container, that is docker pull ghcr.io/conda-incubator/conda-store-ui:sha256-c8c4ab110fec1d39f91ba86df89811bdd5c93bb92037ffb550a684f63ef15c64
I noticed that there are manual steps in RELEASE.md in case the GitHub action fails. Should there be manual steps for how to publish the Docker image? |
Co-authored-by: gabalafou <[email protected]>
714640e
to
b0ec2e1
Compare
|
||
jobs: | ||
build_docker_image: | ||
name: "Build Docker Images 🛠" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the subject of how this appears in the list of checks, currently this shows up as: "Build Docker image / Build Docker Images 🛠️"
I wonder if we can come up with a better combo. Docker / Build image? Not really sure. I also don't think a redundant title is the worst thing in the world (so long as it looks different enough from the other titles)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @soapy1 for addressing my review comments!
I guess we'll find out in the next release if the docker push job works?
b0ec2e1
to
3d462c5
Compare
I tested it out pushing images in the |
follow up to #450
Description
This PR adds 2 new GHA workflows:
Pull request checklist