Show installed version next to requested #454
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabalafou
commented
Feb 20, 2025
| @@ -108,7 +108,7 @@ export const Dependencies = ({ | |||
| <TableRow> | |||
| <TableCell sx={{ fontSize: "13px" }}>Package</TableCell> | |||
| <TableCell sx={{ fontSize: "13px", textAlign: "right" }}> | |||
| Installed Version | |||
| Version | |||
There was a problem hiding this comment.
Looked redundant and potentially confusing to label this column "Installed Version" when:
a. there is no other version column
b. the name of the table is "Installed Packages"
| @@ -34,7 +34,7 @@ export const RequestedPackageList = ({ | |||
| return ( | |||
| <Accordion | |||
| sx={{ | |||
| maxWidth: 420, | |||
| width: 190 * 3, | |||
There was a problem hiding this comment.
Width must be specified in order to use fixed table layout
Comment on lines
+29
to
+30
| const { versionsWithoutConstraints, versionsWithConstraints } = | ||
| useAppSelector(state => state.requestedPackages); |
There was a problem hiding this comment.
This is how its done in the RequestPackagesTableRow component on the edit environment page. (Yes, it's confusing but there are nearly duplicate components for the edit versus view pages.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #364.