Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure settings are retrieved for the right level #1054

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Ensure settings are retrieved for the right level #1054

merged 2 commits into from
Jan 27, 2025

Conversation

soapy1
Copy link
Contributor

@soapy1 soapy1 commented Jan 22, 2025 •
edited
Loading

Description

Follow up to #1044

It ensures that there is consistency in how settings are retrieved throughout the code base and ensures that settings are pulled at the right specificity.

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

@netlify Netlify
Copy link

netlify bot commented Jan 22, 2025 •
edited
Loading

✅ Deploy Preview for conda-store canceled.

Name Link
🔨 Latest commit 19ae010
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/6791634b1c2b16000850bc82

@netlify Netlify
Copy link

netlify bot commented Jan 22, 2025 •
edited
Loading

✅ Deploy Preview for conda-store ready!

Name Link
🔨 Latest commit fee3f12
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/6797e0f8bc69bc00087ef750
😎 Deploy Preview https://deploy-preview-1054--conda-store.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@soapy1 soapy1 force-pushed the get-right-settings branch from 7ea3b5d to d0c6217 Compare January 22, 2025 21:31
@soapy1 soapy1 marked this pull request as draft January 22, 2025 21:35
@soapy1 soapy1 marked this pull request as ready for review January 23, 2025 01:07
@soapy1 soapy1 requested a review from peytondmurray January 23, 2025 01:11
@peytondmurray
Copy link
Contributor

See also #1005.

peytondmurray
peytondmurray reviewed Jan 24, 2025
View reviewed changes
Copy link
Contributor

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor changes/comments, otherwise this is a solid improvement.

@soapy1 soapy1 force-pushed the get-right-settings branch from ff4fec0 to 4aa4de9 Compare January 27, 2025 19:39
@soapy1 soapy1 requested a review from peytondmurray January 27, 2025 19:46
peytondmurray
peytondmurray approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@soapy1 soapy1 merged commit f6c3ed4 into conda-incubator:main Jan 27, 2025
30 checks passed
@soapy1 soapy1 deleted the get-right-settings branch January 27, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peytondmurray peytondmurray peytondmurray approved these changes

Assignees
No one assigned
Labels
area: configuration ⚙️ area: user experience 👩🏻‍💻 Items impacting the end-user experience needs: review 👀 type: enhancement 💅🏼
Projects
conda-store 🐍
Status: Done 💪🏾
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soapy1 @peytondmurray