Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV - Update conda-store build hook #872

Merged
merged 15 commits into from
Sep 11, 2024
Merged

Conversation

trallard
Copy link
Collaborator

Description

Recent updates to conda-store-ui broke the already brittle build process of conda-store-server and conda-store-ui. This PR aims to make this more robust and remove some hacky bits we have relied on until now.

Note that the UI counterpart is at conda-incubator/conda-store-ui#418
so both PRs must be merged for the build and release to work.

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Additional information

This PR not only improves our build process but makes it so that one can build conda-store-server with a local copy repo/copy of conda-store-ui (vs only a released version).
To test these two PRs together:

  1. Check out DEV - Improve bundling and release conda-store-ui#418 in your local clone of conda-store-ui
  2. Bundle the package as if for a release with run webpack:prod bundle
  3. Check out this PR on your local clone of conda-store and cd to conda-store-server
  4. Build conda-store-server with your local copy of conda-store-ui with export LOCAL_UI=<full path to the root the conda-store-ui repo> && hatch build --clean
  5. Run conda-store-server in standalone mode:
# quick way to verify the build
conda-store-server --standalone

You should see the dev version of the UI

image

@trallard trallard added type: enhancement 💅🏼 area: dependencies 📦 Issues related to conda-store dependencies block-release ⛔️ area: javascript Pull requests that update Javascript code labels Sep 10, 2024
Copy link

netlify bot commented Sep 10, 2024

Deploy Preview for conda-store ready!

Name Link
🔨 Latest commit 3f51452
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/66e1b9aa5768ad00082a9fa8
😎 Deploy Preview https://deploy-preview-872--conda-store.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@trallard trallard changed the title DEV - Update conda-store bundling hook DEV - Update conda-store build hook Sep 10, 2024
@peytondmurray peytondmurray merged commit 13c7b79 into main Sep 11, 2024
4 of 5 checks passed
@peytondmurray peytondmurray deleted the trallard/clean-ui-bundle branch September 11, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dependencies 📦 Issues related to conda-store dependencies area: javascript Pull requests that update Javascript code block-release ⛔️ type: enhancement 💅🏼
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

3 participants