-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEV - Update conda-store build hook #872
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trallard
added
type: enhancement 💅🏼
area: dependencies 📦
Issues related to conda-store dependencies
block-release ⛔️
area: javascript
Pull requests that update Javascript code
labels
Sep 10, 2024
✅ Deploy Preview for conda-store ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
gabalafou
reviewed
Sep 10, 2024
trallard
changed the title
DEV - Update conda-store bundling hook
DEV - Update conda-store build hook
Sep 10, 2024
peytondmurray
approved these changes
Sep 10, 2024
Co-authored-by: gabalafou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: dependencies 📦
Issues related to conda-store dependencies
area: javascript
Pull requests that update Javascript code
block-release ⛔️
type: enhancement 💅🏼
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recent updates to conda-store-ui broke the already brittle build process of
conda-store-server
andconda-store-ui
. This PR aims to make this more robust and remove some hacky bits we have relied on until now.Note that the UI counterpart is at conda-incubator/conda-store-ui#418
so both PRs must be merged for the build and release to work.
Pull request checklist
Additional information
This PR not only improves our build process but makes it so that one can build
conda-store-server
with a local copy repo/copy ofconda-store-ui
(vs only a released version).To test these two PRs together:
conda-store-ui
run webpack:prod bundle
conda-store
and cd toconda-store-server
conda-store-server
with your local copy ofconda-store-ui
withexport LOCAL_UI=<full path to the root the conda-store-ui repo> && hatch build --clean
conda-store-server
in standalone mode:You should see the dev version of the UI