-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort envs returned by REST API by current build's scheduled_on time #881
base: main
Are you sure you want to change the base?
Sort envs returned by REST API by current build's scheduled_on time #881
Conversation
✅ Deploy Preview for conda-store ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
7a9b540
to
0d57b2b
Compare
871e0e3
to
0442238
Compare
After a discussion, it seems like no matter how we solve this there's going to be a breaking change to the API. Cursor-based pagination will allow for any sorting order, so I'll look into implementing that, probably through |
Adding pagination via |
Fixes #859.
Description
This PR sorts environments returned when a GET is sent to
/environment/
by the time the environments' current builds were submitted. In systems where users are creating environments while environments are being queried, this ensures that all results are returned; other sorting methods (e.g. by name) can yield incomplete results.Pull request checklist