Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REACT_APP_URL_BASENAME #898

Merged
merged 1 commit into from
Oct 21, 2024
Merged

REACT_APP_URL_BASENAME #898

merged 1 commit into from
Oct 21, 2024

Conversation

gabalafou
Copy link
Contributor

Description

Companion PR to conda-incubator/conda-store-ui#431

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for conda-store canceled.

Name Link
🔨 Latest commit 3e8398e
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/67126d3ef18252000874bfe2

@gabalafou
Copy link
Contributor Author

gabalafou commented Oct 18, 2024

I realized while working on this that we need to have a strategy for how to handle what happens when a user goes directly to a React app-defined route, such as: "/default/new-environment".

Currently, the server will return a 404 instead of returning the conda-store-ui.html page.

I don't know all the ins and outs of the server, but we should probably redirect all unknown routes to the React app.

@gabalafou
Copy link
Contributor Author

gabalafou commented Oct 18, 2024

Created an issue:

Copy link
Collaborator

@trallard trallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gabalafou I had not noticed you opened this PR, thank you!!!

@trallard trallard merged commit aef1c2a into main Oct 21, 2024
27 checks passed
@trallard trallard deleted the url-basename branch October 21, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

2 participants