Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch PackageNotFoundError for DependencyNeedsBuildingError #5257

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Catch PackageNotFoundError for DependencyNeedsBuildingError #5257

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion conda_build/environ.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
LinkError,
LockError,
NoPackagesFoundError,
PackagesNotFoundError,
PaddingError,
UnsatisfiableError,
)
Expand Down Expand Up @@ -965,7 +966,11 @@ def get_install_actions(
with capture():
try:
precs = _install_actions(prefix, index, specs)["LINK"]
except (NoPackagesFoundError, UnsatisfiableError) as exc:
except (
NoPackagesFoundError,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to use the non-aliased ResolvePackageNotFound here for clarification.
(conda.exceptions/conda.exports sets NoPackagesFound = NoPackagesFoundError = ResolvePackageNotFound.)

UnsatisfiableError,
PackagesNotFoundError,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kenodegard, why did we had this change in 7acbbf2 ?
Re-adding PackagesNotFoundError fixes gh-5256. Am I missing something?

Copy link
Contributor

@kenodegard kenodegard Mar 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had added it in the prior commit (7539a73) as I was trying to debug a weird error (see 7acbbf2#r1517170310)

Since the fix had nothing to do with catching PackagesNotFoundError I removed it again

See the full diff for conda_buid.environ https://github.com/conda/conda-build/pull/5203/files#diff-3ba52da5dde963be464da17aa3a40b91541d9709735c97fd03b59d3a0fb54a78R32-R55 doesn't include PackagesNotFoundError before or after

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I landed at 7acbbf2 as the first commit to show the regression but didn't realize that was an intermediate change. Thanks, that's very helpful.
Since 4da3bce works, there must be something in ca792ee (with the get_install_actions name dance applied) that causes it, I think. Let me dig into those changes a bit..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I guess 24.1 didn't show this because d7a9751 broke the "get_install_actions is in the last N entries on the stack" assumption of conda-libmamba-solver.
Meaning, conda-build<24.1 also didn't handle these errors correctly and in fact conda-build=24.1 broke conda-libmamba-solver setting context.offline...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to adjust anything in conda-libmamba-solver?

) as exc:
raise DependencyNeedsBuildingError(exc, subdir=subdir)
except (
SystemExit,
Expand Down
Loading