feat: use python_site_packages_path field when available for installing noarch: python packages, CEP-17 #909
+17
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IndexJson and PackageRecord struct include an optional python_site_packages_path field as specified in CEP-17.
When specified in the packages repodata entry, use the "python_site_packages_path" field for the location of the site_packages_path.
jjhelmus
changed the title
|
This totally seems like the right approach! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the
python_site_packages_pathfield from repodata to set the directory whennoarch: pythonpackages get installed as specified in CEP-17.This the start of an implementation. Wanted to get feedback on the approach before updating other crates and tests.