Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snapshot iterator + CDC #4

Merged
merged 29 commits into from
Oct 4, 2024
Merged

snapshot iterator + CDC #4

merged 29 commits into from
Oct 4, 2024

Conversation

maha-hajja
Copy link
Contributor

Description

Related to #ConduitIO/conduit#1569

Quick checks:

  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@maha-hajja maha-hajja requested a review from a team August 20, 2024 18:27
raulb
raulb reviewed Aug 21, 2024
View reviewed changes
Copy link

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maha-hajja looks like there are still some linting errors. Let me know once this is ready for a full review.

.github/CODEOWNERS Outdated Show resolved Hide resolved
source.go Outdated Show resolved Hide resolved
@maha-hajja maha-hajja marked this pull request as draft August 30, 2024 05:57
@maha-hajja maha-hajja marked this pull request as ready for review September 4, 2024 19:24
@maha-hajja maha-hajja changed the title snapshot iterator snapshot iterator + CDC Sep 4, 2024
@raulb
Copy link

raulb commented Sep 5, 2024

@maha-hajja CI is not happy :(

hariso
hariso reviewed Sep 10, 2024
View reviewed changes
source.go Outdated Show resolved Hide resolved
hariso
hariso reviewed Sep 10, 2024
View reviewed changes
source.go Outdated Show resolved Hide resolved
source.go Show resolved Hide resolved
position/position.go Outdated Show resolved Hide resolved
position/position_test.go Outdated Show resolved Hide resolved
source.go Show resolved Hide resolved
iterator/combined_iterator.go Show resolved Hide resolved
iterator/combined_iterator.go Outdated Show resolved Hide resolved
iterator/combined_iterator.go Outdated Show resolved Hide resolved
iterator/cdc.go Outdated Show resolved Hide resolved
iterator/cdc.go Outdated Show resolved Hide resolved
@maha-hajja maha-hajja requested a review from hariso September 11, 2024 15:06
hariso
hariso reviewed Oct 2, 2024
View reviewed changes
Copy link
Contributor

@hariso hariso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! I posted a few comments, as well as a few questions that will help me understand the code and DynamoDB a bit better.

go.mod Outdated Show resolved Hide resolved
iterator/cdc.go Outdated Show resolved Hide resolved
iterator/cdc.go Outdated Show resolved Hide resolved
iterator/cdc.go Outdated Show resolved Hide resolved
iterator/snapshot.go Outdated Show resolved Hide resolved
source.go Outdated Show resolved Hide resolved
source.go Outdated Show resolved Hide resolved
source.go Outdated Show resolved Hide resolved
iterator/combined_iterator.go Show resolved Hide resolved
iterator/snapshot.go Outdated Show resolved Hide resolved
@maha-hajja maha-hajja requested review from hariso and raulb October 4, 2024 15:14
hariso
hariso approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@hariso hariso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! There area a couple of comments left from the previous review, all are non-blockers.

@maha-hajja maha-hajja merged commit 898eb96 into main Oct 4, 2024
3 checks passed
@maha-hajja maha-hajja deleted the maha/source branch October 4, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hariso hariso hariso approved these changes

@raulb raulb Awaiting requested review from raulb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maha-hajja @raulb @hariso