Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass empty values in CSV for unused fields in delete records #124

Merged
merged 1 commit into from
Jul 15, 2024
Merged

pass empty values in CSV for unused fields in delete records #124

merged 1 commit into from
Jul 15, 2024

Conversation

samirketema
Copy link
Contributor

Description

For deletes, this ensures that we have empty values in CSV fields for everything except:

  • primary key
  • <prefix>_deleted_at
  • <prefix>_operation

We will use the primary key in the MERGE query, and then only update the _deleted_at and _operation fields in the snowflake destination table.

Manual testing is in progress.

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@samirketema samirketema requested a review from a team as a code owner July 15, 2024 19:40
simonl2002
simonl2002 approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@simonl2002 simonl2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@samirketema samirketema merged commit 671448d into main Jul 15, 2024
3 checks passed
@samirketema samirketema deleted the samir/fix-csv-error-deletes branch July 15, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonl2002 simonl2002 simonl2002 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samirketema @simonl2002