Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

Reflect latest SW updates (latest: 5.6.4) #34

Open
wants to merge 49 commits into
base: 2.0
Choose a base branch
from

Conversation

thomasfrobieter
Copy link

@thomasfrobieter thomasfrobieter changed the title Fixed the option to order without regsiter an account Fixed the option to order without register an account May 9, 2019
@uehler
Copy link
Member

uehler commented May 9, 2019

thank you @thomasfrobieter!
Looks good to me. @benjamin-ott will have a look too.

Is this a Shopware 5.5 related Fix?

@uehler uehler requested a review from benjamin-ott May 9, 2019 10:15
@thomasfrobieter
Copy link
Author

Is this a Shopware 5.5 related Fix?

Not sure. I've just grabbed it from the bare theme, because we missed the option since we switched to the Bootstrap theme.

@JPustkuchen
Copy link

Well done, confirming fixes!

@JPustkuchen
Copy link

We're using it with 5.5.8!

JPustkuchen and others added 7 commits June 4, 2019 15:07
Fixed order of supplier info & links like in bootstrap Bare default.
Fixed tabs links in custom parent pages to link to the link instead of the custom page URL, if a custom link is set. Furthermore added data-attributes and target like in menu links.
Added bootstrap document templates
Added document templates from bare to make documents work.
…-templates

Add Bare document templates to bootstrap theme
{if {config name=showCompanySelectField}} vs {if {config name=showCompanySelectField} == 0}
thomasfrobieter and others added 13 commits July 11, 2019 10:52
…elect field, because many customers missed changing this field, so all of them where "male".

Hint: In different to bare, we had to remove the disabled attribute from the newly added option, because the javascript which creates the stylable select box, ignores disabled items. Howewer, it works fine due to the empty value attribute.
… library modifications as possible. Remaining required library modifications are caused by SW mistakes and their missing development against interfaces / plugins. Hopefully this will be solved in SW core in the future.
@JPustkuchen
Copy link

@thomasfrobieter: Please Update the title to "Reflect latest SW updates (latest: 5.6.4)" because this pull request references a branch which exactly does that.

@thomasfrobieter thomasfrobieter changed the title Fixed the option to order without register an account Reflect latest SW updates (latest: 5.6.4) Jan 16, 2020
Added condition like in Bare Theme for frontend_index_footer_last_articles
blog_id parameter was missing so blog views were not counted
@uehler
Copy link
Member

uehler commented Jul 10, 2020

Hey @thomasfrobieter

thank you for your PR and sorry for the big delay.
Your pull requests contains a lot of unrelated changes, could you fix that please?

and please target the dev branch, which will be merged into the 2.0 branch soon.

@JPustkuchen
Copy link

Same reason as written in my other comment. We made a mistake and didn't create a separate branch for each fix so that the pull requests contain merged changes from the referenced issues.

Most simple solution would be to review and apply the latest commit to that branch which contains all changes from different issues then. Otherwise someone would have to split the single commits into separate branches and connect them to their issues, which is also not too hard.

JPustkuchen and others added 8 commits June 30, 2021 11:19
… was compiled by making services public.

The "swf_bootstrap_theme.services.theme_config_reader" service or alias has been removed or inlined when the container was compiled. You should either make it public, or stop using the container directly and use dependency injection instead. in vendor/symfony/dependency-injection/Container.php on line 275
Improved compatibility with Responsive Theme which uses jquery.modal.js
Add regulationPrice (SW 5.7.8)
Added bootstrap classes
The SWS Bootstrap theme has a wrong smarty block structure, so the hidden form fields added by the shopware unified Paypal plugin, are added OUTSIDE the form, so the checkout ends up with an error like: 

Unable to load template snippet  'frontend/paypal_unified_v2/index.tpl|frontend/plugins/seo/index.tpl' in   /usr/www/users/duesing/engine/Library/Smarty/sysplugins/smarty_internal_templatebase.php  on line 127
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order as a guest / don't create account option is not available
3 participants