Skip to content
This repository has been archived by the owner on Nov 21, 2023. It is now read-only.

Commit

Permalink
verifier: tdx: Add more unit tests
Browse files Browse the repository at this point in the history 
Added a unit test for `parse_kernel_parameters()`.

Signed-off-by: James O. D. Hunt <[email protected]>
  • Loading branch information
@jodh-intel
jodh-intel committed Nov 16, 2023
1 parent a19eb66 commit 9605dbd
Show file tree
Hide file tree
Showing 2 changed files with 226 additions and 3 deletions.
3 changes: 2 additions & 1 deletion Cargo.lock
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

226 changes: 224 additions & 2 deletions attestation-service/src/verifier/tdx/claims.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -226,11 +226,11 @@ fn parse_kernel_parameters(kernel_parameters: &[u8]) -> Result<Map<String, Value
#[cfg(test)]
mod tests {
use assert_json_diff::assert_json_eq;
use serde_json::json;
use serde_json::{json, to_value, Value};

use crate::verifier::tdx::{eventlog::CcEventLog, quote::parse_tdx_quote};

use super::generate_parsed_claim;
use super::{generate_parsed_claim, parse_kernel_parameters};

#[test]
fn parse_tdx_claims() {
Expand Down Expand Up @@ -275,4 +275,226 @@ mod tests {

assert_json_eq!(expected, claims);
}

#[test]
fn test_parse_kernel_parameters() {
#[derive(Debug)]
struct TestData<'a> {
params: &'a [u8],
fail: bool,
result: Vec<(String, Value)>,
}

let tests = &[
TestData {
params: b"",
fail: false,
result: vec![],
},
// Invalid UTF8 data
TestData {
params: b"\xff\xff",
fail: true,
result: vec![],
},
// Invalid UTF8 data
TestData {
params: b"foo=\xff\xff",
fail: true,
result: vec![],
},
TestData {
params: b"name_only",
fail: false,
result: vec![("name_only".into(), Value::Null)],
},
TestData {
params: b"a=b",
fail: false,
result: vec![("a".into(), to_value("b").unwrap())],
},
TestData {
params: b"\ra=b",
fail: false,
result: vec![("a".into(), to_value("b").unwrap())],
},
TestData {
params: b"\na=b",
fail: false,
result: vec![("a".into(), to_value("b").unwrap())],
},
TestData {
params: b"a=b\nc=d",
fail: false,
result: vec![
("a".into(), to_value("b").unwrap()),
("c".into(), to_value("d").unwrap()),
],
},
TestData {
params: b"a=b\n\nc=d",
fail: false,
result: vec![
("a".into(), to_value("b").unwrap()),
("c".into(), to_value("d").unwrap()),
],
},
TestData {
params: b"a=b\rc=d",
fail: false,
result: vec![
("a".into(), to_value("b").unwrap()),
("c".into(), to_value("d").unwrap()),
],
},
TestData {
params: b"a=b\r\rc=d",
fail: false,
result: vec![
("a".into(), to_value("b").unwrap()),
("c".into(), to_value("d").unwrap()),
],
},
TestData {
params: b"a=b\rc=d\ne=foo",
fail: false,
result: vec![
("a".into(), to_value("b").unwrap()),
("c".into(), to_value("d").unwrap()),
("e".into(), to_value("foo").unwrap()),
],
},
TestData {
params: b"a=b\rc=d\nname_only\0e=foo",
fail: false,
result: vec![
("a".into(), to_value("b").unwrap()),
("c".into(), to_value("d").unwrap()),
("name_only".into(), Value::Null),
("e".into(), to_value("foo").unwrap()),
],
},
TestData {
params: b"foo='bar'",
fail: false,
result: vec![("foo".into(), to_value("'bar'").unwrap())],
},
TestData {
params: b"foo=\"bar\"",
fail: false,
result: vec![("foo".into(), to_value("\"bar\"").unwrap())],
},
// Spaces in parameter values are not supported.
// XXX: Note carefully the apostrophe values below!
TestData {
params: b"params_with_spaces_do_not_work='a b c'",
fail: false,
result: vec![
("b".into(), Value::Null),
("c'".into(), Value::Null),
(
"params_with_spaces_do_not_work".into(),
to_value("'a").unwrap(),
),
],
},
TestData {
params: b"params_with_spaces_do_not_work=\"a b c\"",
fail: false,
result: vec![
("b".into(), Value::Null),
("c\"".into(), Value::Null),
(
"params_with_spaces_do_not_work".into(),
to_value("\"a").unwrap(),
),
],
},
// Params containing equals in their values are silently dropped
TestData {
params: b"a==",
fail: false,
result: vec![],
},
TestData {
params: b"a==b",
fail: false,
result: vec![],
},
TestData {
params: b"a==b=",
fail: false,
result: vec![],
},
TestData {
params: b"a=b=c",
fail: false,
result: vec![],
},
TestData {
params: b"a==b=c",
fail: false,
result: vec![],
},
TestData {
params: b"module_foo=bar=baz,wibble_setting=2",
fail: false,
result: vec![],
},
TestData {
params: b"a=b c== d=e",
fail: false,
result: vec![
("a".into(), to_value("b").unwrap()),
("d".into(), to_value("e").unwrap()),
],
},
];

for (i, d) in tests.iter().enumerate() {
let msg = format!(
"test[{}]: {:?} (params: {:?})",
i,
d,
String::from_utf8_lossy(&d.params.to_vec()),
);

let result = parse_kernel_parameters(d.params);

let msg = format!("{}: actual result: {:?}", msg, result);

if std::env::var("DEBUG").is_ok() {
eprintln!("DEBUG: {}", msg);
}

if d.fail {
assert!(result.is_err(), "{}", msg);
continue;
}

let result = result.unwrap();
let actual_count = result.len();

let expected_count = d.result.len();

let msg = format!("{}: actual_count: {:?}", msg, actual_count);

assert_eq!(actual_count, expected_count, "{}", msg);

for expected_kv in &d.result {
let key = &expected_kv.0;
let value = &expected_kv.1;

let value_found = result.get(key);

let kv_msg = format!("{}: key: {:?}, value: {:?}", msg, key, value);

assert!(value_found.is_some(), "{}", kv_msg);

let value_found = value_found.unwrap();

assert_eq!(value_found, value, "{}", kv_msg);
}
}
}
}

0 comments on commit 9605dbd

Please sign in to comment.