Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDH | Multiple CDH instances in ttrpc CDH process #688

Closed
Xynnn007 opened this issue Aug 21, 2024 · 0 comments · Fixed by #727
Closed

CDH | Multiple CDH instances in ttrpc CDH process #688

Xynnn007 opened this issue Aug 21, 2024 · 0 comments · Fixed by #727
Assignees
@Xynnn007
Labels
cdh Confidential Data Hub

Comments

@Xynnn007
Copy link
Member

Currently we are using a macro to create structures that handles different API of CDH. Because of the limit of ttrpc, we should create a separate Server struct for every server, this would occupy 4~ memory than only one Server struct.

Let's fix this by multiplex one Server struct after containerd/ttrpc-rust#235 gets merged.
@Xynnn007 Xynnn007 self-assigned this Aug 21, 2024
@Xynnn007 Xynnn007 added the cdh Confidential Data Hub label Aug 23, 2024
Xynnn007 added a commit to Xynnn007/guest-components that referenced this issue Sep 27, 2024
@Xynnn007
CDH: fix ttrpc cdh memory occupation
ee65f67 
Fixes confidential-containers#688

This commit will copy only the pointer of CDH to implement different
APIs. In old version, each CDH instance will serve for one API, thus
occupies multiple times of memory.

Signed-off-by: Xynnn007 <[email protected]>
@Xynnn007 Xynnn007 mentioned this issue Sep 27, 2024
Merged
Xynnn007 added a commit to Xynnn007/guest-components that referenced this issue Sep 27, 2024
@Xynnn007
CDH: fix ttrpc cdh memory occupation
387e3cb 
Fixes confidential-containers#688

This commit will copy only the pointer of CDH to implement different
APIs. In old version, each CDH instance will serve for one API, thus
occupies multiple times of memory.

Signed-off-by: Xynnn007 <[email protected]>
Xynnn007 added a commit to Xynnn007/guest-components that referenced this issue Oct 3, 2024
@Xynnn007
CDH: fix ttrpc cdh memory occupation
6f3c091 
Fixes confidential-containers#688

This commit will copy only the pointer of CDH to implement different
APIs. In old version, each CDH instance will serve for one API, thus
occupies multiple times of memory.

Signed-off-by: Xynnn007 <[email protected]>
Xynnn007 added a commit to Xynnn007/guest-components that referenced this issue Oct 8, 2024
@Xynnn007
CDH: fix ttrpc cdh memory occupation
e6be168 
Fixes confidential-containers#688

This commit will copy only the pointer of CDH to implement different
APIs. In old version, each CDH instance will serve for one API, thus
occupies multiple times of memory.

Signed-off-by: Xynnn007 <[email protected]>
Xynnn007 added a commit that referenced this issue Oct 17, 2024
@Xynnn007
CDH: fix ttrpc cdh memory occupation
76980cf 
Fixes #688

This commit will copy only the pointer of CDH to implement different
APIs. In old version, each CDH instance will serve for one API, thus
occupies multiple times of memory.

Signed-off-by: Xynnn007 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Xynnn007 Xynnn007

Labels
cdh Confidential Data Hub
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CDH | Fix ttrpc memory bug and gRPC lock bug Xynnn007/guest-components
1 participant
@Xynnn007