CDH | Fix ttrpc memory bug and gRPC lock bug #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xynnn007
force-pushed
the
fix-cdh-memory
branch
from
299aa28 to
95521ea
Compare
|
this PR could also undo/revert e3c3fef, right? |
Xynnn007
force-pushed
the
fix-cdh-memory
branch
from
78d6fd6 to
470afc6
Compare
right. Added the commit |
mythi
reviewed
Oct 3, 2024
attestation-agent/attestation-agent/src/bin/ttrpc-aa/ttrpc_protocol/attestation_agent.rs
Show resolved
Hide resolved
Fixes confidential-containers#688 This commit will copy only the pointer of CDH to implement different APIs. In old version, each CDH instance will serve for one API, thus occupies multiple times of memory. Signed-off-by: Xynnn007 <[email protected]>
The pull_image API of CDH is marked as Fn not FnMut thus we do not need a RwLock to protect the synchronization. Also, fixes a bug that CDH does not support image pull gRPC. Signed-off-by: Xynnn007 <[email protected]>
Upstream ttrpc crate has fixed the usage of boxed pointers. Thus we do not need to declare explicitly the lint error ignorance. Signed-off-by: Xynnn007 <[email protected]>
Xynnn007
force-pushed
the
fix-cdh-memory
branch
from
470afc6 to
22f6885
Compare
This commit adds a Makefile option `lint` for attestation-agent to test the lint of all sub projects of AA. Before this patch, some ttrpc codes are not covered by CI. Signed-off-by: Xynnn007 <[email protected]>
Xynnn007
force-pushed
the
fix-cdh-memory
branch
from
22f6885 to
e0b5a56
Compare
|
Hey @mythi Could you help to get another look? |
mythi
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the commit message for details.
Fixes #688