aa: attester: Let attesters to prepare reportdata #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this old |
mythi
force-pushed
the
hasher
branch
3 times, most recently
from
a28d693 to
fd0681d
Compare
Similar to how CoCo attestation-service has per TEE verifier logic knowing how to verify the report data evidence, make it the same on the attesters side too. Instead of KBS protocol doing the nonce + tee_pubkey hashing to be used in the evidence reportdata, pass the information to attesters to crunch. Additionally, hash the full tee_pubkey info as specified by the KBS protocol specification: "The hash of the tee-pubkey field must be included in the custom field of HW-TEE evidence and signed by HW-TEE hardware." Signed-off-by: Mikko Ylinen <[email protected]>
For better compatibility with different attestation services, move Intel SGX and Intel TDX to use Sha256 and Sha512 hashers, respectively. Signed-off-by: Mikko Ylinen <[email protected]>
Signed-off-by: Mikko Ylinen <[email protected]>
|
I think coupling the report data calculation insde attester is not a good choice. Different users would want to calculate report data with different algorithms. This PR would reduce flexibility. |
|
not needed anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #366
Mostly build-tested only so keeping in draft for now.