Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDH/eHSM: add features for eHSM support #409

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

Xynnn007
Copy link
Member

  1. Both Ehsm and ehsm should be supported when a sealed secret indicates the kms type
  2. added ehsm feature to confidential data hub binary build to leaverage the ability.

@Xynnn007 Xynnn007 requested a review from sameo as a code owner December 14, 2023 02:35
@Xynnn007
Copy link
Member Author

cc @1570005763

Copy link
Contributor

@1570005763 1570005763 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (merge conflict)

1. Both `Ehsm` and `ehsm` should be supported when a sealed secret
indicates the kms type
2. added ehsm feature to confidential data hub binary build to leaverage
the ability.

Signed-off-by: Xynnn007 <[email protected]>
Added the statement for Intel Ehsm for KMS plugins. Fixed the Makefile
to follow the readme, s.t. If no `PROVIDER` is given, all features will
be enabled.

Signed-off-by: Xynnn007 <[email protected]>
@Xynnn007 Xynnn007 merged commit a129710 into confidential-containers:main Dec 15, 2023
4 checks passed
@Xynnn007 Xynnn007 deleted the fix-ehsm-feat branch December 15, 2023 02:10
@arronwy
Copy link
Member

arronwy commented Dec 15, 2023

verified unseal secrets with eHSM, thanks a lot! @Xynnn007 @1570005763

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants