Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images-rs: clarify comments in image config file #843

Merged

Conversation

fitzthum
Copy link
Member

I said I would update these comments back when we refactored the config file and now I have finally done it.

No functional changes. Hopefully this helps. These comments are fairly important because they describe a couple of features that aren't widely documented.

@fitzthum fitzthum requested a review from a team as a code owner December 11, 2024 20:39
Copy link

@huoqifeng huoqifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks! @fitzthum

Copy link
Member

@Xynnn007 Xynnn007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! @fitzthum

image-rs/src/config.rs Outdated Show resolved Hide resolved
No functional changes. Adjust the wording in the comments
that describe the image-rs configuration.

These comments are fairly important given that they describe
how to use several features.

Signed-off-by: Tobin Feldman-Fitzthum <[email protected]>
@fitzthum fitzthum force-pushed the imagers-config-comments branch from 81f6f79 to 3fead68 Compare December 12, 2024 15:32
@fitzthum fitzthum merged commit 0562e63 into confidential-containers:main Dec 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants