CI Documentation - added machine list table and label columns #317
Conversation
ryansavino
force-pushed
the
ci-doc-amd-nodes
branch
from
d7ce14c to
0aa1da9
Compare
|
hi @ryansavino , I think that a separated table only to map label -> machine would be better. |
|
lgtm; wainer's comment is fine, too, if you think it would help |
|
Looks good to me as is in the single table (it's not that wide) although I'm having troubles actually finding the pipeline definitions (tried searching for the name as well as the labels). Are they supposed to be already there? |
ryansavino
force-pushed
the
ci-doc-amd-nodes
branch
2 times, most recently
from
8efd6ad to
daacda4
Compare
|
I've updated this PR with the machine table as well. @wainersm let me know what you think. I can add other system labels if you guys know what they are. @BbolroC @stevenhorsman @fidencio Question: default CcRuntime is referring to runtime class? Should I add that column in the job table? @ldoktor the AMD nodes are already labeled. |
ryansavino
force-pushed
the
ci-doc-amd-nodes
branch
from
daacda4 to
87d7b94
Compare
ryansavino
force-pushed
the
ci-doc-amd-nodes
branch
from
87d7b94 to
0e23b73
Compare
ryansavino
requested review from
portersrc,
fitzthum,
fidencio and
AdithyaKrishnan
Please, if possible, do.
So, for the TDX machine the label is |
ryansavino
force-pushed
the
ci-doc-amd-nodes
branch
from
0e23b73 to
11d55be
Compare
ryansavino
changed the title
ryansavino
force-pushed
the
ci-doc-amd-nodes
branch
from
11d55be to
905ee43
Compare
Done. |
docs/DEVELOPMENT.md
Outdated
| | az-ubuntu-2004 | virtual | Non-TEE | | | ||
| | az-ubuntu-2204 | virtual | Non-TEE | | |
There was a problem hiding this comment.
I don't think we use these runners any more, but just the github hosted ones?
docs/DEVELOPMENT.md
Outdated
| | --- | --- | --- | --- | | ||
| | az-ubuntu-2004 | virtual | Non-TEE | | | ||
| | az-ubuntu-2204 | virtual | Non-TEE | | | ||
| | s390x-runner-01 | virtual | Non-TEE | S390X | |
There was a problem hiding this comment.
For the runner s390x-runner-01, s390x and s390x-large are used. There is another one named s390x-runner-02 whose label is only s390x.
There was a problem hiding this comment.
So the final status would look like:
| s390x-runner-01 | virtual | Non-TEE | s390x, s390x-large
| s390x-runner-02 | virtual | Non-TEE | s390x
ryansavino
force-pushed
the
ci-doc-amd-nodes
branch
2 times, most recently
from
c4bcf57 to
b62e9d9
Compare
docs/DEVELOPMENT.md
Outdated
| |operator enclave-cc e2e tests| Intel SGX (Simulated Mode) | Ubuntu 22.04 | | ||
| | Job name | TEE | OS | Required Labels | | ||
| | --- | --- | --- | --- | | ||
| | operator enclave-cc e2e tests | Intel SGX (Simulated Mode) | Ubuntu 22.04 | ubuntu-22.04 | |
There was a problem hiding this comment.
I think the Required Labels can be dropped from this line here.
The added machine table links the machine's assigned labels to the jobs required labels. Corrected some mistakes and label assignments. Formatting. Fixes: confidential-containers#316 Signed-Off-By: Ryan Savino <[email protected]>
ryansavino
force-pushed
the
ci-doc-amd-nodes
branch
from
b62e9d9 to
af41ab1
Compare
fidencio
merged commit 511f62a
into
confidential-containers:main
The added machine table links the machine's assigned labels to the jobs required labels.
Corrected some mistakes and label assignments.
Formatting.
Fixes: #316
Signed-Off-By: Ryan Savino [email protected]