doc: Include custom build for DEVELOPMENT.md #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The e2e test for s390x runs successfully (https://github.com/confidential-containers/operator/actions/runs/7564405180) |
|
@BbolroC - can you re-based this to pick up the latest CI changes please (though I know it's doc, so not likely to impact them). Thanks |
BbolroC
force-pushed
the
update-doc-custom-build
branch
from
4d7af98 to
f92ebab
Compare
wainersm
reviewed
Jan 18, 2024
docs/DEVELOPMENT.md
Outdated
| popd | ||
| ``` | ||
|
|
||
| Additionally, there are alternative patch layers such as `peer-pods` or `s390x` in addition to the `default` layer. You may switch the directory accordingly based on your requirements. |
There was a problem hiding this comment.
hi @BbolroC !
Not sure if you really meant patch layers or path layers. In any case, kustomize uses the jargon "overlay" to mean those directories, i.e., those are "kustomize overlay directories".
There was a problem hiding this comment.
Thanks for the info. I will update the doc. 😉
The DEVELOPMENT.md lacks a case where a user wants to build/test a custom operator/payload image. This is to supplement those instructions for the case. This also covers an update on the incorrect information for s390x e2e test. Signed-off-by: Hyounggyu Choi <[email protected]>
BbolroC
force-pushed
the
update-doc-custom-build
branch
from
f92ebab to
5824ff5
Compare
dcmiddle
approved these changes
Jan 18, 2024
wainersm
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DEVELOPMENT.md does not cover a case where a user wants to build/test a custom operator/payload image. This is to supplement the case. This also covers an update on the incorrect information for s390x e2e test.
This PR should be merged after an e2e test for s390x in #295 runs properly.
Signed-off-by: Hyounggyu Choi [email protected]