ccruntime: Remove cleanup #411
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fidencio
force-pushed
the
topic/kata-doesnt-require-cleanup-anymore
branch
2 times, most recently
from
e719b1c to
66dfad8
Compare
It's not needed anymore for the CC Runtime, as Kata Containers does the cleanup as part of the uninstall. See: kata-containers/kata-containers@8d9bec2 Calling the cleanup after calling the uninstall, which has already done the cleanup, could result on a infinite loop. Signed-off-by: Fabiano Fidêncio <[email protected]>
fidencio
force-pushed
the
topic/kata-doesnt-require-cleanup-anymore
branch
from
66dfad8 to
2879312
Compare
|
@fidencio even though it doesn't fix the original issue this PR should be still valid, shouldn't it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not needed anymore for the CC Runtime, as Kata Containers does the cleanup as part of the uninstall.
See: kata-containers/kata-containers@8d9bec2
Calling the cleanup after calling the uninstall, which has already done the cleanup, could result on a infinite loop.