Extend TdInfo struct to add vcpu_index field #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyao1
reviewed
Jun 17, 2024
tdx-tdcall/src/tdx.rs
Outdated
| @@ -37,6 +37,7 @@ pub struct TdInfo { | |||
| pub attributes: u64, | |||
| pub max_vcpus: u32, | |||
| pub num_vcpus: u32, | |||
| pub vcpu_index: u32, | |||
| pub rsvd: [u64; 3], | |||
There was a problem hiding this comment.
If we add u32, we need reduce u32 from rsvd. For example,
pub rsvd1: u32,
pub rsvd: [u64; 2],
There was a problem hiding this comment.
yes, since pub vcpu_index: u32 was added, to maintain the same struct size, pub rsvd: [u64; 3] was modified to pub rsvd: [u32; 5].
jyao1
reviewed
Jun 17, 2024
tdx-tdcall/src/tdx.rs
Outdated
| @@ -700,7 +702,7 @@ mod tests { | |||
| fn test_struct_size_alignment() { | |||
| assert_eq!(align_of::<TdxDigest>(), 64); | |||
| assert_eq!(size_of::<TdxDigest>(), 64); | |||
| assert_eq!(size_of::<TdInfo>(), 48); | |||
| assert_eq!(size_of::<TdInfo>(), 56); | |||
Signed-off-by: OuyangHang33 <[email protected]>
vijaydhanraj
approved these changes
Jun 17, 2024
jyao1
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #708
add vcpu_index field