-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor corrections #2
Open
adams85
wants to merge
14
commits into
master
Choose a base branch
from
minor-corrections
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
z4kn4fein
approved these changes
Nov 8, 2024
adams85
force-pushed
the
minor-corrections
branch
2 times, most recently
from
November 8, 2024 20:01
832ab4b
to
17efa93
Compare
adams85
force-pushed
the
minor-corrections
branch
from
November 8, 2024 20:03
17efa93
to
46003aa
Compare
adams85
force-pushed
the
minor-corrections
branch
8 times, most recently
from
November 13, 2024 13:16
408626a
to
9110ba7
Compare
adams85
force-pushed
the
minor-corrections
branch
from
November 13, 2024 21:21
9110ba7
to
9688ece
Compare
Quality Gate failedFailed conditions See analysis details on SonarQube Cloud Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the purpose of your pull request
Bug fixes:
browser
andchrome-extension
platforms to work correctly in web workers too.DefaultQueryStringProvider
to make it work in web workers (aswindow
global variable is not available web workers.)Breaking changes:
SettingKeyValue
to a plain object type. (Very low impact expected. It's unlikely that consumers create instances of this type but even then they may not use the ctor.)FlagOverrides
to a plain object type. (Internal breaking change only.)LocalStorageCache
toLocalStorageConfigCache
andChromeLocalStorageCache
toChromeLocalStorageConfigCache
. (Internal breaking change only.)Related issues (only if applicable)
n/a
Requirement checklist (only if applicable)