Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor corrections #2

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Minor corrections #2

wants to merge 14 commits into from

Conversation

adams85
Copy link
Collaborator

@adams85 adams85 commented Nov 8, 2024

Describe the purpose of your pull request

Bug fixes:

  • Adjusts the browser and chrome-extension platforms to work correctly in web workers too.
    • Implements an IndexedDB-backed config cache and uses it when running in a web worker (as LocalStorage is not available in web workers).
    • Corrects DefaultQueryStringProvider to make it work in web workers (as window global variable is not available web workers.)
    • Also, adds a sample app which runs the SDK in a web worker.
  • A bunch of minor corrections (especially to project and build configuration).

Breaking changes:

  • Change SettingKeyValue to a plain object type. (Very low impact expected. It's unlikely that consumers create instances of this type but even then they may not use the ctor.)
  • Change FlagOverrides to a plain object type. (Internal breaking change only.)
  • Rename LocalStorageCache to LocalStorageConfigCache and ChromeLocalStorageCache to ChromeLocalStorageConfigCache. (Internal breaking change only.)

Related issues (only if applicable)

n/a

Requirement checklist (only if applicable)

  • I have covered the applied changes with automated tests.
  • I have executed the full automated test set against my changes.
  • I have validated my changes against all supported platform versions.
  • I have read and accepted the contribution agreement.

@adams85 adams85 force-pushed the minor-corrections branch 2 times, most recently from 832ab4b to 17efa93 Compare November 8, 2024 20:01
@adams85 adams85 force-pushed the minor-corrections branch 8 times, most recently from 408626a to 9110ba7 Compare November 13, 2024 13:16
Copy link

sonarcloud bot commented Nov 15, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4.2% Duplication on New Code (required ≤ 3%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants