Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator metadata update and queries #91

Merged
merged 7 commits into from
Aug 17, 2021
Merged

Validator metadata update and queries #91

merged 7 commits into from
Aug 17, 2021

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Aug 13, 2021

This PR adds another step in the integration of the PoE module in the app stack

CLI updates

  • Queries
tgrade q poe:

  unbonding-period Query the global unbonding period
  validator        Query a validator
  validators       Query for all validators
  • Commands
tgrade tx poe

  edit-validator   edit an existing validator account

Not included:

@alpe alpe marked this pull request as ready for review August 15, 2021 09:19
@alpe alpe marked this pull request as draft August 15, 2021 09:35
@alpe alpe marked this pull request as ready for review August 15, 2021 10:45
@alpe alpe requested a review from ethanfrey August 15, 2021 10:46
Copy link
Contributor

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This review was mainly stream of consciousness of my reactions.

Many places are just my question as to how things work.
A few suggestions to change (which may be ignored if I understand incorrectly).

The changes look big and generally proper. I will look how these build in the other PR now.

app/app.go Show resolved Hide resolved
app/export.go Show resolved Hide resolved
app/app.go Show resolved Hide resolved
app/app.go Show resolved Hide resolved
app/app.go Show resolved Hide resolved
x/poe/keeper/keeper.go Show resolved Hide resolved
x/poe/keeper/msg_server.go Show resolved Hide resolved
x/poe/keeper/msg_server.go Show resolved Hide resolved
x/poe/keeper/msg_server_test.go Show resolved Hide resolved
x/poe/stakingadapter/keeper.go Show resolved Hide resolved
@ethanfrey
Copy link
Contributor

Looks like you addressed my concerns.

Let's merge this and move onto the next ones.

@ethanfrey ethanfrey merged commit 3decfb1 into main Aug 17, 2021
@ethanfrey ethanfrey deleted the 87-expose-new-func branch August 17, 2021 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose new contract functionality commands Update validator Meta data
2 participants