Show user full name in confluent iam rbac role-binding list (#2611)

confluentinc · Feb 12, 2024 · 32acf01 · 32acf01
1 parent 26f02cc
commit 32acf01
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 18 deletions.
diff --git a/internal/iam/command_rbac_role_binding_list.go b/internal/iam/command_rbac_role_binding_list.go
@@ -500,6 +500,7 @@ func (c *roleBindingCommand) ccloudListRolePrincipals(cmd *cobra.Command, listRo
 		row := &roleBindingListOut{Principal: principal}
 		if user, ok := principalToUser[principal]; ok {
 			row.Email = user.GetEmail()
+			row.Name = user.GetFullName()
 			list.Add(row)
 		}
 		if name, ok := serviceAccountToNameMap[principal]; ok {

diff --git a/test/fixtures/output/iam/rbac/role-binding/list-user-clusteradmin-cloud.golden b/test/fixtures/output/iam/rbac/role-binding/list-user-clusteradmin-cloud.golden
@@ -1,6 +1,6 @@
-   Principal   | Name |        Email          
----------------+------+-----------------------
-  User:u-11aaa |      | [email protected]  
-  User:u-22bbb |      | [email protected]  
-  User:u-33ccc |      | [email protected]  
-  User:u-44ddd |      | [email protected]      
+   Principal   |   Name   |        Email          
+---------------+----------+-----------------------
+  User:u-11aaa | 11 Aaa   | [email protected]  
+  User:u-22bbb | 22 Bbb   | [email protected]  
+  User:u-33ccc | 33 Ccc   | [email protected]  
+  User:u-44ddd | Muwei He | [email protected]      
diff --git a/test/fixtures/output/iam/rbac/role-binding/list-user-clusteradmin-json-cloud.golden b/test/fixtures/output/iam/rbac/role-binding/list-user-clusteradmin-json-cloud.golden
@@ -1,22 +1,22 @@
 [
   {
     "principal": "User:u-11aaa",
-    "name": "",
+    "name": "11 Aaa",
     "email": "[email protected]"
   },
   {
     "principal": "User:u-22bbb",
-    "name": "",
+    "name": "22 Bbb",
     "email": "[email protected]"
   },
   {
     "principal": "User:u-33ccc",
-    "name": "",
+    "name": "33 Ccc",
     "email": "[email protected]"
   },
   {
     "principal": "User:u-44ddd",
-    "name": "",
+    "name": "Muwei He",
     "email": "[email protected]"
   }
 ]
diff --git a/test/fixtures/output/iam/rbac/role-binding/list-user-clusteradmin-yaml-cloud.golden b/test/fixtures/output/iam/rbac/role-binding/list-user-clusteradmin-yaml-cloud.golden
@@ -1,12 +1,12 @@
 - principal: User:u-11aaa
-  name: ""
+  name: 11 Aaa
   email: [email protected]
 - principal: User:u-22bbb
-  name: ""
+  name: 22 Bbb
   email: [email protected]
 - principal: User:u-33ccc
-  name: ""
+  name: 33 Ccc
   email: [email protected]
 - principal: User:u-44ddd
-  name: ""
+  name: Muwei He
   email: [email protected]
diff --git a/test/fixtures/output/iam/rbac/role-binding/list-user-envadmin-cloud.golden b/test/fixtures/output/iam/rbac/role-binding/list-user-envadmin-cloud.golden
@@ -1,3 +1,3 @@
-   Principal   | Name |        Email          
----------------+------+-----------------------
-  User:u-22bbb |      | [email protected]  
+   Principal   |  Name  |        Email          
+---------------+--------+-----------------------
+  User:u-22bbb | 22 Bbb | [email protected]  
diff --git a/test/fixtures/output/iam/rbac/role-binding/list-user-orgadmin-cloud.golden b/test/fixtures/output/iam/rbac/role-binding/list-user-orgadmin-cloud.golden
@@ -3,4 +3,4 @@
   User:group-abc  | another-group-mapping |                       
   User:pool-12345 | identity-pool         |                       
   User:sa-12345   | service-account       |                       
-  User:u-11aaa    |                       | [email protected]  
+  User:u-11aaa    | 11 Aaa                | [email protected]