-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues with flink application list command #2909
base: main
Are you sure you want to change the base?
Conversation
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Can you add a description under the bug fix section in the PR description?
Our release notes are auto generated from PR descriptions.
f5ae20e
@@ -5,10 +5,9 @@ import ( | |||
) | |||
|
|||
type flinkApplicationSummaryOut struct { | |||
Name string `human:"Name" serialized:"name"` | |||
Environment string `human:"Environment" serialized:"environment"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a breaking change (environment).
Release Notes
Breaking Changes
New Features
Environment
from theflink application list
command.Bug Fixes
flink application list
command if any of the attributes was null.Checklist
What
In the
flink application list --output human
command, we did not have null check on the properties we want to show in the application summary command. But this is a valid situation, when application is created, it can havejobName
as null till it starts and same for status.This PR adds check on those attributes.
Note:
json
andyaml
output works fineThe other fix that we want to change in the same command is that we have removed
spec.flinkEnvironment
from flink application. The changes have to be made to theEnvironment
from theconfluent flink application list --environment env
. The env is already there in the command.flinkEnvironment
will no longer be a part of the response of describe and list applications, it is removed from the test files.References
Test & Review