Update pipeline and linter #2940
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
Comment on lines
+82
to
+84
| ifneq ($(shell cat .go-version),$(shell go list -m -f '{{.GoVersion}}')) | ||
| $(error The go versions in go.mod and .go-version must match) | ||
| endif |
There was a problem hiding this comment.
Make a note that when ServiceBot does this for us, we can remove this check?
There was a problem hiding this comment.
I don't think we want to remove it. The problem this is designed to block is someone making a manual update to the go.mod version without also changing the .go-version.
If the service bot updates both at once, there's no issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes
Breaking Changes
New Features
Bug Fixes
Checklist
What
.go-versionand thego.modversion in the lint target to make sure they match.References
Test & Review