-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ruleSet and KMS setting for CLI CSFLE during init #2942
base: main
Are you sure you want to change the base?
Conversation
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @channingdong , left some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @channingdong , LGTM
…ate test cases accordingly
27bb169
to
5cbc67b
Compare
This reverts commit 5cbc67b.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After syncing w/ Channing: we need to make the proto files available even when users don't have any copy on their machine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Release Notes
This PR serves as a following up PR to finalize the CSFLE feature on CLI, including the following changes:
Breaking Changes
New Features
ruleSet
and Key Management Service (KMS) driver support to finalize the Client Side Field Level Encryption (CSFLE) feature forconfluent kafka topic [produce | consume]
Bug Fixes
Checklist
What
ruleSet
can be extracted correctly from the native Go object.ruleSet
correctly.confluent-kafka-go
library to latest version.References
https://docs.confluent.io/cloud/current/security/encrypt/csfle/overview.html
Test & Review
Thorough manual verification have been conducted to test different types (string, JSON, Prototype, Avro) of schemas with simple, reference, nested and ruleSet (with KMS) features, which all show the passing result.
The details verification result under different category can be found here:
https://docs.google.com/document/d/1GwXz9hNOkub_Br-2nssoYWCf6elZBvwo7TMhCNYinwE/edit?tab=t.0#heading=h.1xcbdvagwov4