[CLI-3355] Fix some confluent kafka topic consume errors
#2970
+35
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
Comment on lines
+252
to
+258
| // Fetch the current SR cluster id and endpoint | ||
| if srEndpoint == "" { | ||
| srClusterId, srEndpoint, err = c.GetCurrentSchemaRegistryClusterIdAndEndpoint() | ||
| if err != nil { | ||
| return err | ||
| } | ||
| } |
There was a problem hiding this comment.
What if srEndpoint is not empty, so the srClusterId will not set, during normal consume without srClusterId the deserializer couldn't be initialized correctly.
Not sure if that's the case and being tested?
Comment on lines
+643
to
+650
| var srClusterId string | ||
| if (schemaId.IsSet() || schema != "") && srEndpoint == "" { | ||
| srClusterId, srEndpoint, err = c.GetCurrentSchemaRegistryClusterIdAndEndpoint() | ||
| if err != nil { | ||
| return nil, nil, err | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Same here, will the basic produce have issues with the empty srClusterId if srEndpoint is passed from customer flag?
channingdong
requested changes
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes
Breaking Changes
New Features
Bug Fixes
confluent kafka topic consumeconfluent kafka topic [produce | consume] --bootstrapChecklist
What
GetDataplaneTokencall will fail for users consuming from a cloud cluster using--bootstrapwhile logged out, so this PR adds a check that the user is logged in before attempting to get the tokenReferences
Test & Review
Tested with the following.
confluent kafka topic consume -b confluent-audit-log-eventsconfluent kafka topic [produce | consume] -b confluent-audit-log-events --bootstrap <endpoint> --api-key <api_key> --api-secret <api_secret>confluent kafka topic produce <topic> --bootstrap <cluster_endpoint> --api-key <api_key> --api-secret <api_secret> --value-format protobuf --schema <schema_id> --schema-registry-endpoint <sr_endpoint> --schema-registry-api-key <sr_key> --schema-registry-api-secret <sr_secret>