Pool or otherwise remove some buffers in StringAsPinnedUTF8
on NET6+
#2208
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR targets .NET6+ but all of the targeted APIs are also available on lower runtimes if dependencies were to be taken on NuGet packages such as
System.Buffers
.The PR avoids double-allocation of buffers and adds array pooling to the needed buffer to reduce memory usage to a consistent value independent of payload size while also improving a bit of the performance.
Benchmarks (using .NET8 runtime)